Review main Merged

65070[BUGFIX] Add missing css class to create new IRRE relations

Nicole Hummel CR +2 V +2 Easy +1 −1 updated 07/24/20, 21:27

Commit message

This patch adds the missing css class to get the "add new relation" button for
IRRE selector fields working again.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Nicole Hummel uploaded patch set 1 07/22/20, 14:44

  2. Nicole Hummel updated the commit message in patch set 2 07/22/20, 14:47

  3. TYPO3com voted on patch set 1 V +1 07/22/20, 14:59 Completed build in 14m 28s on Wed, 22 Jul, 02:59 PM Test Summary: 72907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4194

  4. TYPO3com voted on patch set 2 V +1 07/22/20, 15:02 Completed build in 14m 00s on Wed, 22 Jul, 03:02 PM Test Summary: 72909 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4195

  5. Christian Kuhn commented on patch set 2 07/23/20, 20:55

    Hey. Looks straight but I don't fully understand *which* actual button is affected here. Would you like to add a screenshot to the issue and/or pick an example from ext:styleguide that shows the behavior in question? Would help a lot on testing :)
  6. Christian Kuhn commented on patch set 2 V +1 CR +1 07/23/20, 22:48

    Nevermind. Reproducible with ext:styleguide, with created default records, page inline usecombination, button "create new record". added a screeni to forge. The button works in v9 and broke somewhere since v10. Tested patch in both v10 and master. Works.
  7. Oli Bartsch voted on patch set 2 V +1 CR +1 07/24/20, 06:40

  8. Daniel Goerz voted on patch set 2 V +2 CR +2 07/24/20, 08:43

  9. Daniel Goerz merged patch set 3 07/24/20, 08:43

  10. Benni Mack commented on patch set 3 V +1 CR +1 07/24/20, 21:27

    thanks!