Review main Merged

65076[BUGFIX] Translation wizard shows correct elements in workspace

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 07/23/20, 19:49

Commit message

Since #89555 versioned records do not have pid=-1 set anymore,
but the uid of the live page or live placeholder record.
The translation modal of the page module to create records for
a translated page now shows records twice.
Solution is to use the correct database restriction to suppress
retrieval of versioned records of the translation source, those
are handled via BackendUtility::workspaceOL() already.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • David Steeb +1
  • Verified V +2 Done
    • Benni Mack +2
    • David Steeb +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 07/23/20, 13:35

  2. TYPO3com voted on patch set 1 V +1 07/23/20, 13:47 Completed build in 11m 29s on Thu, 23 Jul, 01:47 PM Test Summary: 72921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4204

  3. Benni Mack voted on patch set 1 V +1 CR +1 07/23/20, 14:12

  4. David Steeb commented on patch set 1 V +1 CR +1 07/23/20, 16:14

    Tested, worked fine for my use case.
  5. Benni Mack voted on patch set 1 V +2 CR +2 07/23/20, 19:49

  6. Benni Mack merged patch set 2 07/23/20, 19:49