65078[BUGFIX] Use correct configuration for typo3/cms-frontend/base-redirect-resolver
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1925
-
Georg Ringer uploaded patch set 1 07/23/20, 19:10
-
Georg Ringer commented on patch set 1 07/23/20, 19:10
This change is ready for review. -
TYPO3com voted on patch set 1 V -1 07/23/20, 19:21 Completed build in 11m 15s on Thu, 23 Jul, 07:21 PM Test Summary: 458 of 73408 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4206
-
Benni Mack commented on patch set 1 07/23/20, 20:23
10.4 as well, right? -
Daniel Goerz commented on patch set 1 07/24/20, 09:06
Currently the base-redirect middleware come right before the static-route-resolver, the order being: * typo3/cms-frontend/site * typo3/cms-frontend/backend-user-authentication * typo3/cms-frontend/authentication * typo3/cms-redirects/redirecthandler * typo3/cms-frontend/base-redirect-resolver * typo3/cms-frontend/static-route-resolver With the patch applied, this order does not change on my installation. However, the functionals seem to have a big issue with this change. -
TYPO3com commented on patch set 1 07/24/20, 09:07 Completed build in 14h 08m 28s on Fri, 24 Jul, 09:07 AM Test Summary: 458 of 73408 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4206
-
Benni Mack rebased onto patch set 2 08/07/20, 15:48
-
TYPO3com voted on patch set 2 V -1 08/07/20, 16:02 Completed build in 13m 54s on Fri, 7 Aug, 04:02 PM Test Summary: 461 of 73455 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4487
-
Christian Kuhn rebased onto patch set 3 08/18/20, 17:27
-
Christian Kuhn commented on patch set 3 08/18/20, 17:27
rebased to see what happens ... -
Christian Kuhn commented on patch set 3 08/18/20, 17:30
At least it is clearly a bug this middleware references a non existing middleware in after, and it should be fixed. -
TYPO3com voted on patch set 3 V -1 08/18/20, 17:39 Completed build in 12m 10s on Tue, 18 Aug, 05:39 PM Test Summary: 461 of 73482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4763
-
Christian Kuhn commented on patch set 3 08/18/20, 17:42
unsure on what exactly happens in ordering shuffling with this patch. needs investigation. -
Christian Kuhn voted on patch set 3 CR -1 08/18/20, 17:42
-
Daniel Goerz commented on patch set 3 09/04/20, 14:30
Same error exists in the testing framework and causes problems in the build when this patch is applied, we need to fix TF and raise the version to make this patch work. https://github.com/TYPO3/testing-framework/pull/198 -
Benni Mack uploaded patch set 4 09/23/20, 14:41
-
TYPO3com voted on patch set 4 V +1 09/23/20, 15:05 Completed build in 14m 06s on Wed, 23 Sep, 03:05 PM Test Summary: 73680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5871
-
Benni Mack commented on patch set 4 09/23/20, 15:06
needs a new release for the testing framework. -
Benni Mack voted on patch set 4 CR -1 09/23/20, 15:06
-
Benni Mack uploaded patch set 5 09/30/20, 06:19
-
TYPO3com voted on patch set 5 V +1 09/30/20, 06:33 Completed build in 13m 41s on Wed, 30 Sep, 06:33 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6079
-
Benni Mack voted on patch set 5 V +1 CR +1 09/30/20, 06:49
-
Daniel Goerz voted on patch set 5 V +2 CR +2 09/30/20, 07:21
-
Daniel Goerz merged patch set 6 09/30/20, 07:21
-
Markus Klein commented on patch set 6 04/28/21, 13:25
This desperately misses a backport to v10. It's wrong there as well