Review main Merged

65081[FEATURE] Add `expandAll` option for renderType=selectCheckBox

TYPO3com CR +2 V +2 Normal +60 −1 updated 11/10/20, 21:39

Commit message

The renderType `selectCheckbox` allows for grouping of items,
which are rendered as collapsed per default.

A new TCA setting now allows to define this behavior for all
groups at once. By adding the new setting `expandAll=true`,
all groups are initially expanded. If not set or set to FALSE
the current behvahiour remains and all groups are collapsed.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1521

  1. TYPO3com uploaded patch set 1 07/24/20, 07:51

  2. TYPO3com voted on patch set 1 V -1 07/24/20, 07:51 Completed build in 25s on Fri, 24 Jul, 07:51 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4220

  3. Anja Leichsenring uploaded patch set 2 07/25/20, 10:46

  4. Anja Leichsenring uploaded patch set 3 07/25/20, 10:46

  5. TYPO3com voted on patch set 2 V -1 07/25/20, 10:47 Completed build in 52s on Sat, 25 Jul, 10:47 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4247

  6. Anja Leichsenring commented on patch set 3 07/25/20, 10:48

    I created an example in ext:styleguide for testing: https://github.com/TYPO3/styleguide/pull/146
  7. Anja Leichsenring updated the commit message in patch set 4 07/25/20, 10:57

  8. TYPO3com voted on patch set 3 V +1 07/25/20, 11:00 Completed build in 13m 53s on Sat, 25 Jul, 11:00 AM Test Summary: 72930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4248

  9. TYPO3com voted on patch set 4 V +1 07/25/20, 11:13 Completed build in 13m 24s on Sat, 25 Jul, 11:13 AM Test Summary: 72929 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4251

  10. Christian Kuhn commented on patch set 4 CR -1 07/27/20, 16:53

    Let us keep this on hold until ext:styleguide 10 branch is created, the styleguide PR is merged to styleguide master (since this feature here will not go to v10), and the styleguide tests are green again ...
  11. Jörg Bösche commented on patch set 4 09/02/20, 07:24

    > Patch Set 4: Code-Review-1 > > Let us keep this on hold until ext:styleguide 10 branch is created, the styleguide PR is merged to styleguide master (since this feature here will not go to v10), and the styleguide tests are green again ... Last activity was in July 2020. Do you have an update for us? Can we review, approve, and merge the patch set for now? :-) Patchset works for me. Tested on master.
  12. Anja Leichsenring commented on patch set 4 09/17/20, 19:27

    > Patch Set 4: > > > Patch Set 4: Code-Review-1 > > > > Let us keep this on hold until ext:styleguide 10 branch is created, the styleguide PR is merged to styleguide master (since this feature here will not go to v10), and the styleguide tests are green again ... > > Last activity was in July 2020. Do you have an update for us? Can we review, approve, and merge the patch set for now? :-) > > Patchset works for me. Tested on master. styleguide PR still not accepted.
  13. Oli Bartsch commented on patch set 4 CR -1 09/17/20, 20:37

    SelectCheckBoxElement.php:224 Unresolved

    This will trigger a "Undefined array key" PHP warning. Should be something like: $expandState = (bool)($config['expandAll'] ?? false) ? 'in' : ''; $html[] = '<div id="' . $groupIdCollapsible . '" class="panel-collapse collapse ' . $expandAll . '" role="tabpanel">'; This also avoids unnecessary if/else complexity. Furthermore I strongly advise not to use `expandAll` as first level but, for consistency across TCA types (see `group`, `inline`, ...), to use `appearance` here instead.

    Feature-91859-AllowDividedSelectCheckBoxSectionToBeInitiallyExpanded.rst:14 Unresolved

    groups

    Feature-91859-AllowDividedSelectCheckBoxSectionToBeInitiallyExpanded.rst:43 Unresolved

    group

    Feature-91859-AllowDividedSelectCheckBoxSectionToBeInitiallyExpanded.rst:43 Unresolved

    without having to open each select group individually.
  14. Oli Bartsch uploaded patch set 5 10/13/20, 08:14

  15. Oli Bartsch voted on patch set 5 V +1 CR +1 10/13/20, 08:14

  16. Oli Bartsch commented on patch set 5 10/13/20, 08:15

    A styleguide example is available for this patch. See the issue.
  17. TYPO3com voted on patch set 5 V +1 10/13/20, 08:29 Completed build in 15m 31s on Tue, 13 Oct, 08:29 AM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6463

  18. Anja Leichsenring commented on patch set 5 11/03/20, 18:35

    > Patch Set 5: > > A styleguide example is available for this patch. See the issue. here: https://github.com/TYPO3/styleguide/pull/146 still open
  19. Christian Kuhn voted on patch set 5 V +1 CR +1 11/10/20, 21:39

  20. Anja Leichsenring voted on patch set 5 V +2 CR +2 11/10/20, 21:39

  21. Anja Leichsenring merged patch set 6 11/10/20, 21:39