Review main Merged

65083[BUGFIX] Allow more than 999 subpages in link browser pagetree

Jigal van Hemert CR +2 V +2 Easy +1 −1 updated 08/04/20, 18:51

Commit message

The variable $crazyRecursionLimiter actually limits the number
of subpages that are rendered for each page and not the depth
of recursive calls to getTree(). This limit only affects the
browsable pagetree in for example the link browser and not the
pagetree in the navigation pane.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Richard Haeser +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Jigal van Hemert uploaded patch set 1 07/24/20, 11:30

  2. TYPO3com voted on patch set 1 V +1 07/24/20, 11:42 Completed build in 12m 04s on Fri, 24 Jul, 11:42 AM Test Summary: 72920 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4224

  3. Richard Haeser voted on patch set 1 CR +1 07/24/20, 13:41

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 07/25/20, 16:29

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 07/27/20, 12:02

  6. Daniel Goerz commented on patch set 1 CR -1 07/27/20, 15:23

    AbstractTreeView.php:732

    This is somehow funny now. We have a $crazyRecursionLimiter that does not prevent recursion and is set to such a high value that it does not limit either. So, my suggestions would be to * either remove it completely (why do we stop at 9999 now?) * set it to the count() of records in the pages table Also renaming this variable to $maxSubPages or something like that seems reasonable.
  7. Christian Kuhn commented on patch set 1 07/27/20, 16:58

    AbstractTreeView.php:732 Reply Unresolved

    In this case I'd rather opt to remove that funny thing altogether. It's an ancient leftover in the first place I guess.
  8. Anja Leichsenring commented on patch set 1 07/28/20, 07:22

    see request in Slack that provoked the change as given here: https://typo3.slack.com/archives/C03AM9R17/p1595499923403200
  9. Daniel Goerz commented on patch set 1 CR 0 07/28/20, 07:48

    Actually I should not block this change as I am not 100% sure about possible side effects
  10. Anja Leichsenring voted on patch set 1 V +2 CR +2 08/04/20, 18:51

  11. Anja Leichsenring merged patch set 2 08/04/20, 18:51