Review main Merged

65084[BUGFIX] Correctly remove added items from unique selectbox

Nicole Hummel CR +2 V +2 Easy +4 −2 updated 07/27/20, 10:19

Commit message

This patch adds the current selected value in the parents selectbox if no
uid is set in its data attributes. This ensures that the value is removed
from the option list on adding the inline element.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • Nicole Hummel +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 711

  1. Nicole Hummel uploaded patch set 1 07/24/20, 12:18

  2. TYPO3com voted on patch set 1 V -1 07/24/20, 12:30 Completed build in 11m 44s on Fri, 24 Jul, 12:30 PM Test Summary: 72921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4225

  3. Andreas Kienast uploaded patch set 2 07/25/20, 05:02

  4. TYPO3com voted on patch set 2 V -1 07/25/20, 05:13 Completed build in 10m 56s on Sat, 25 Jul, 05:13 AM Test Summary: 12 of 73408 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4231

  5. TYPO3com commented on patch set 2 07/25/20, 05:39 Completed build in 47m 47s on Sat, 25 Jul, 05:39 AM Test Summary: 1 of 73408 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4231

  6. Andreas Kienast uploaded patch set 3 07/25/20, 06:11

  7. TYPO3com voted on patch set 3 V +1 07/25/20, 06:22 Completed build in 11m 12s on Sat, 25 Jul, 06:22 AM Test Summary: 72921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4232

  8. Andreas Kienast voted on patch set 3 V +1 CR +1 07/25/20, 06:28

  9. Nicole Hummel voted on patch set 3 V +1 CR +1 07/27/20, 08:53

  10. Daniel Goerz voted on patch set 3 V +2 CR +2 07/27/20, 10:18

  11. Daniel Goerz merged patch set 4 07/27/20, 10:19