Review main Merged

65085[TASK] Allow typo3/cms to be installed with Composer 2

Helmut Hummel CR +2 V +2 Hard +282 −78 updated 07/24/20, 14:30

Commit message

Currently the dev dependency ocramius/package-versions does not
work with Composer 2. To overcome this, Composer published
an API compatible package which can be used as replacement.

This does not affect any published package. It is only
a preparation to be able to switch to Composer 2
for testing and packaging.

composer req --dev composer/package-versions-deprecated --no-update
composer up typo3/cms-composer-installers composer/package-versions-deprecated ocramius/package-versions

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Simon Gilli +1
    • Manuel Selbach +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 710

  1. Helmut Hummel uploaded patch set 1 07/24/20, 12:38

  2. Helmut Hummel uploaded patch set 2 07/24/20, 12:47

  3. Helmut Hummel uploaded patch set 3 07/24/20, 12:50

  4. TYPO3com voted on patch set 1 V +1 07/24/20, 12:50 Completed build in 11m 48s on Fri, 24 Jul, 12:50 PM Test Summary: 72921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4226

  5. TYPO3com voted on patch set 2 V +1 07/24/20, 12:59 Completed build in 11m 44s on Fri, 24 Jul, 12:59 PM Test Summary: 72921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4227

  6. TYPO3com voted on patch set 3 V +1 07/24/20, 13:03 Completed build in 13m 32s on Fri, 24 Jul, 01:03 PM Test Summary: 72921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4228

  7. Manuel Selbach voted on patch set 3 CR +1 07/24/20, 13:51

  8. Simon Gilli commented on patch set 3 V +1 CR +1 07/24/20, 14:21

    What I don't fully get, why are various packages from vendor symplify updated? Version did not change, the refs only. So did they a force push?
  9. Frank Nägler voted on patch set 3 V +2 CR +2 07/24/20, 14:30

  10. Frank Nägler merged patch set 4 07/24/20, 14:30