Review main Merged

65089[BUGFIX] Respect different matcher config of ConstructorArgumentMatcher

Anja Leichsenring CR +2 V +2 Normal +97 −37 updated 07/27/20, 16:27

Commit message

The extensionScannerRstFileReferences check expects rstFiles listed
in first level of the configuration array. ConstructorArgumentMatcher
puts them in the second level. Thus, no files are found during the
check, indicated by PHP warnings.

The rstFiles given to ConstructorArgumentMatcher have never been
checked due to this incompatibility.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1217

  1. Anja Leichsenring uploaded patch set 1 07/25/20, 08:06

  2. TYPO3com voted on patch set 1 V -1 07/25/20, 08:07 Completed build in 24s on Sat, 25 Jul, 08:07 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4238

  3. Anja Leichsenring uploaded patch set 2 07/25/20, 08:09

  4. Andreas Kienast voted on patch set 2 CR +1 07/25/20, 08:13

  5. TYPO3com voted on patch set 2 V +1 07/25/20, 08:22 Completed build in 13m 15s on Sat, 25 Jul, 08:22 AM Test Summary: 72921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4239

  6. Andreas Kienast voted on patch set 2 V +1 07/25/20, 08:32

  7. Oliver Hader commented on patch set 2 CR -1 07/25/20, 10:28

    On it...
  8. Oliver Hader uploaded patch set 3 07/25/20, 10:42

  9. TYPO3com voted on patch set 3 V -1 07/25/20, 10:43 Completed build in 22s on Sat, 25 Jul, 10:43 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4245

  10. Oliver Hader uploaded patch set 4 07/25/20, 10:44

  11. Oliver Hader commented on patch set 4 07/25/20, 10:46

    I took the chance to speed up this script by avoiding checking the file system again and again: before: Build/Scripts/extensionScannerRstFileReferences.php 25.63s user 6.61s system 99% cpu 32.412 total after: Build/Scripts/extensionScannerRstFileReferences.php 0.15s user 0.06s system 80% cpu 0.264 total
  12. Oliver Hader voted on patch set 4 V +1 CR +1 07/25/20, 10:46

  13. TYPO3com voted on patch set 4 V -1 07/25/20, 10:56 Completed build in 11m 48s on Sat, 25 Jul, 10:56 AM Test Summary: 1 of 73417 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4246

  14. TYPO3com voted on patch set 4 V +1 07/25/20, 11:02 Completed build in 29m 33s on Sat, 25 Jul, 11:02 AM Test Summary: 72930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4246

  15. Christian Kuhn voted on patch set 4 V +1 CR +1 07/27/20, 10:51

  16. Oliver Hader voted on patch set 4 V +2 CR +2 07/27/20, 16:27

  17. Oliver Hader merged patch set 5 07/27/20, 16:27