Review 9.5 Merged

65094[BUGFIX] Deleting a localized page deletes its localized records

Andreas Kienast CR +2 V +2 Normal +208 −31 updated 07/27/20, 10:48

Commit message

This fixes an issue that has been in the core "since ever":
Have a localized page with localized records on it. If the
page localization is deleted (for instance via list module),
its localized records are NOT marked as deleted. They are
not shown anymore since the localized page record is gone,
but they're still there. If later a localization of this page
with the same sys_language_uid is created again, the records
magically reappear.
The patch changes DataHandler->deleteSpecificPage() to delete
localized records of localized pages correctly for the
sys_language_uid in question if the table is localization
aware.
An edge case within workspace is handled to suppress the
cascading delete while swapping pages.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 810

  1. Andreas Kienast commented on patch set 1 07/25/20, 08:54

    Cherry Picked from branch 10.4. The following files contain Git conflicts: * typo3/sysext/core/Classes/DataHandling/DataHandler.php * typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php * typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php * typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php * typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/ActionTest.php
  2. TYPO3com voted on patch set 1 V -1 07/25/20, 08:55 Completed build in 48s on Sat, 25 Jul, 08:55 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-714

  3. Andreas Kienast uploaded patch set 2 07/25/20, 09:23

  4. Andreas Kienast commented on patch set 2 07/25/20, 09:23

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 07/25/20, 09:37 Completed build in 13m 53s on Sat, 25 Jul, 09:37 AM Test Summary: 75058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-715

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 07/25/20, 13:08

  7. Daniel Goerz commented on patch set 2 V -1 07/27/20, 09:54

    Testing this in a project, please wait with merging
  8. Daniel Goerz voted on patch set 2 V +1 CR +1 07/27/20, 10:15

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 07/27/20, 10:47

  10. Andreas Kienast merged patch set 3 07/27/20, 10:48