Review 10.4 Merged

65098[BUGFIX] Correctly remove added items from unique selectbox

Daniel Goerz CR +2 V +2 Easy +4 −2 updated 07/27/20, 11:39

Commit message

This patch adds the current selected value in the parents selectbox if no
uid is set in its data attributes. This ensures that the value is removed
from the option list on adding the inline element.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Daniel Goerz commented on patch set 1 07/27/20, 10:19

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/InlineControlContainer.js
  2. Daniel Goerz uploaded patch set 2 07/27/20, 10:24

  3. Daniel Goerz commented on patch set 2 07/27/20, 10:24

    This change is ready for review.
  4. TYPO3com voted on patch set 1 V -1 07/27/20, 10:33 Completed build in 13m 58s on Mon, 27 Jul, 10:33 AM Test Summary: 12 of 74473 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-117

  5. TYPO3com voted on patch set 2 V +1 07/27/20, 10:38 Completed build in 12m 46s on Mon, 27 Jul, 10:38 AM Test Summary: 73989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-118

  6. Daniel Goerz voted on patch set 2 V +2 CR +2 07/27/20, 11:39

  7. Daniel Goerz merged patch set 3 07/27/20, 11:39