Review 10.4 Merged

65104[TASK] Restore order of class members in extbase's ActionController

Daniel Goerz CR +2 V +2 Hard +189 −189 updated 07/29/20, 07:31

Commit message

Per convention, extbase controllers define first fields,
then inject methods, then initialize methods.
All other functions follow behind.

In order to ease reading in this big class, the lost order following
this convention is restored.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 07/29/20, 06:51

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 07/29/20, 07:06 Completed build in 14m 37s on Wed, 29 Jul, 07:06 AM Test Summary: 73989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-133

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 07/29/20, 07:31

  4. Anja Leichsenring merged patch set 2 07/29/20, 07:31