Review main Merged

65116[BUGFIX] Fix slug handling for sites not on root level

Helmut Hummel CR +2 V +2 Easy +3 −0 updated 08/06/20, 12:18

Commit message

Only try to fetch translated uids for translated records,
and provide is_siteroot field for slug helper,
so that it can be checked if slug is generated for a site root.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Froemken +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 67

  1. Helmut Hummel uploaded patch set 1 07/26/20, 14:19

  2. TYPO3com voted on patch set 1 V +1 07/26/20, 14:31 Completed build in 11m 21s on Sun, 26 Jul, 02:31 PM Test Summary: 72928 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4257

  3. Benni Mack voted on patch set 1 V +1 CR +1 08/03/20, 20:27

  4. Andreas Kienast voted on patch set 1 CR +1 08/06/20, 09:30

  5. Stefan Froemken voted on patch set 1 V +1 08/06/20, 09:34

  6. Benni Mack commented on patch set 1 V +2 CR +2 08/06/20, 10:56

    @helhum - please merge
  7. Helmut Hummel merged patch set 2 08/06/20, 12:18