Review 10.4 Merged

65117[BUGFIX] If is_regexp = 1 then source_path must wrap in #

Mohsin Khan CR +2 V +2 Easy +1 −1 updated 10/08/20, 04:32

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Markus Klein +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Mohsin Khan uploaded patch set 1 07/27/20, 10:33

  2. TYPO3com voted on patch set 1 V +1 07/27/20, 10:48 Completed build in 14m 03s on Mon, 27 Jul, 10:47 AM Test Summary: 73989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-120

  3. Markus Klein commented on patch set 1 CR -1 07/27/20, 10:49

    Thanks for your contribution! Please always push patches for the master branch first. The backports will be taken care of by the Core developer after the initial patch is merged in master. Your releases line shall target: master, 10.4, 9.5
  4. Mohsin Khan updated the commit message in patch set 2 08/29/20, 13:16

  5. TYPO3com voted on patch set 2 V +1 08/29/20, 13:28 Completed build in 12m 12s on Sat, 29 Aug, 01:28 PM Test Summary: 74061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-292

  6. Oliver Klee commented on patch set 2 CR -1 08/29/20, 16:06

    Just setting my -1 until the master version of this change set has been merged.
  7. Markus Klein updated the commit message in patch set 3 10/06/20, 06:28

  8. Markus Klein wrote 10/06/20, 06:30

    Removed Code-Review-1 by Markus Klein <markus.klein@typo3.org>
  9. Markus Klein voted on patch set 3 V +1 CR +1 10/06/20, 06:32

  10. Josef Glatz commented on patch set 3 10/06/20, 06:41

    For the records: this is the mentioned related patch in the master: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65007
  11. Josef Glatz voted on patch set 3 V +1 CR +1 10/06/20, 06:41

  12. TYPO3com voted on patch set 3 V +1 10/06/20, 06:48 Completed build in 19m 14s on Tue, 6 Oct, 06:48 AM Test Summary: 74778 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-570

  13. Georg Ringer voted on patch set 3 V +2 CR +2 10/08/20, 04:32

  14. Georg Ringer merged patch set 4 10/08/20, 04:32