Review 9.5 Merged

65119[BUGFIX] Respect different matcher config of ConstructorArgumentMatcher

Oliver Hader CR +2 V +2 Normal +97 −37 updated 07/27/20, 16:48

Commit message

The extensionScannerRstFileReferences check expects rstFiles listed
in first level of the configuration array. ConstructorArgumentMatcher
puts them in the second level. Thus, no files are found during the
check, indicated by PHP warnings.

The rstFiles given to ConstructorArgumentMatcher have never been
checked due to this incompatibility.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Oliver Hader uploaded patch set 1 07/27/20, 16:32

  2. TYPO3com voted on patch set 1 V -1 07/27/20, 16:32 Completed build in 23s on Mon, 27 Jul, 04:32 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-724

  3. Oliver Hader uploaded patch set 2 07/27/20, 16:33

  4. TYPO3com voted on patch set 2 V +1 07/27/20, 16:47 Completed build in 13m 47s on Mon, 27 Jul, 04:47 PM Test Summary: 75136 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-725

  5. Oliver Hader voted on patch set 2 V +2 CR +2 07/27/20, 16:48

  6. Oliver Hader merged patch set 3 07/27/20, 16:48