Review main Merged

65121[TASK] Restore order of class members in extbase's ActionController

Anja Leichsenring CR +2 V +2 Hard +189 −189 updated 07/29/20, 06:50

Commit message

Per convention, extbase controllers define first fields,
then inject methods, then initialize methods.
All other functions follow behind.

In order to ease reading in this big class, the lost order following
this convention is restored.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Markus Klein +1
    • Simon Gilli +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Markus Klein +1
    • Simon Gilli +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Anja Leichsenring uploaded patch set 1 07/27/20, 19:22

  2. Anja Leichsenring uploaded patch set 2 07/27/20, 19:25

  3. TYPO3com voted on patch set 1 V +1 07/27/20, 19:33 Completed build in 11m 27s on Mon, 27 Jul, 07:33 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4276

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 07/27/20, 19:34

  5. TYPO3com voted on patch set 2 V +1 07/27/20, 19:37 Completed build in 11m 47s on Mon, 27 Jul, 07:37 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4277

  6. Markus Klein voted on patch set 2 V +1 CR +1 07/28/20, 20:21

  7. Simon Gilli voted on patch set 2 V +1 CR +1 07/28/20, 20:21

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 07/29/20, 06:16

  9. Daniel Goerz voted on patch set 2 V +2 CR +2 07/29/20, 06:47

  10. Daniel Goerz merged patch set 3 07/29/20, 06:50