Review main Merged

65132[BUGFIX] No bogus log entries when discarding workspace records

Christian Kuhn CR +2 V +2 Easy +8 −1 updated 07/29/20, 10:02

Commit message

Selecting a page and records on the page to be discarded in the
workspace module can lead to log entries that records could not
be deleted.
This can happen when discarding (deleting) a page that only exists
in the workspace already has deleted records on the page. The explicit
call to delete single records then creates this log.
The solution is to ask the DataHandler if the record in question
has already been deleted to avoid deletion in this case.
Additionally, the log entry now contains the table:uid to
make it more useful in case it pops up again.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 812

  1. Christian Kuhn uploaded patch set 1 07/28/20, 12:37

  2. Christian Kuhn updated the commit message in patch set 2 07/28/20, 12:45

  3. TYPO3com voted on patch set 1 V +1 07/28/20, 12:49 Completed build in 12m 15s on Tue, 28 Jul, 12:49 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4283

  4. TYPO3com voted on patch set 2 V +1 07/28/20, 12:59 Completed build in 13m 45s on Tue, 28 Jul, 12:59 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4284

  5. Christian Kuhn updated the commit message in patch set 3 07/28/20, 18:11

  6. TYPO3com voted on patch set 3 V +1 07/28/20, 18:25 Completed build in 13m 50s on Tue, 28 Jul, 06:25 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4287

  7. Andreas Kienast updated the commit message in patch set 4 07/29/20, 07:57

  8. Andreas Kienast voted on patch set 4 CR +1 07/29/20, 07:57

  9. TYPO3com voted on patch set 4 V +1 07/29/20, 08:08 Completed build in 11m 05s on Wed, 29 Jul, 08:08 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4296

  10. Benni Mack voted on patch set 4 V +1 CR +1 07/29/20, 08:13

  11. Daniel Goerz voted on patch set 4 V +2 CR +2 07/29/20, 10:02

  12. Daniel Goerz merged patch set 5 07/29/20, 10:02