Review 9.5 Abandoned

65133[BUGFIX] Removed calls to undefined methods

Richard Haeser CR 0 V 0 Easy +8 −11 updated 08/11/20, 12:04

Commit message

As the JavaScript for the page tree was altered with fixing
the performance issue of the page tree, some calls to
methods that are undefined in v9 remained. Those calls are
now replaced by v9 compatible code.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 2

Review log 1113

  1. Richard Haeser uploaded patch set 1 07/28/20, 14:58

  2. TYPO3com voted on patch set 1 V +1 07/28/20, 15:11 Completed build in 12m 36s on Tue, 28 Jul, 03:11 PM Test Summary: 75134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-731

  3. Sybille Peters commented on patch set 1 V -1 07/28/20, 16:13

    Still get message "Page tree error" and JavaScript errors in SvgTree.js line 298: Uncaught SyntaxError: Unexpected end of JSON input In the line 284: (d3.json(this.settings.dataUrl) message: "Cannot read property 'dataUrl' of undefined" stack: "TypeError: Cannot read property 'dataUrl' of undefined↵ at eval (eval at <anonymous> (http://t3coredev9/typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js?bust=b9abf8dc7cadbc94540d1578ff830fba67693967:285:11), <anonymous>:1:15)↵ at Object.<anonymous> (http://t3coredev9/typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js?bust=b9abf8dc7cadbc94540d1578ff830fba67693967:285:11)↵ at V.call (http://t3coredev9/typo3/sysext/core/Resources/Public/JavaScript/Contrib/d3/d3.js?bust=b9abf8dc7cadbc94540d1578ff830fba67693967:8:3594)↵ at XMLHttpRequest.c (http://t3coredev9/typo3/sysext/core/Resources/Public/JavaScript/Contrib/d3/d3.js?bust=b9abf8dc7cadbc94540d1578ff830fba67693967:6:16671)"; __proto__: Error
  4. Oliver Hader commented on patch set 1 07/29/20, 10:29

    Hm, that means `this.loadData()` is called from a wrong/missing scope... not clear which one currently...
  5. Andreas Kienast commented on patch set 1 07/30/20, 09:34

    PageTreeToolbar.js:172 Unresolved

    This is handled in a separate patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65141
  6. Andreas Kienast commented on patch set 1 07/30/20, 09:41

    > Patch Set 1: Verified-1 > > Still get message "Page tree error" and JavaScript errors in SvgTree.js line 298: I cannot reproduce this issue with the configuration of #91878. What does your setup look like?
  7. Andreas Kienast updated the commit message in patch set 2 07/30/20, 09:43

  8. TYPO3com voted on patch set 2 V +1 07/30/20, 09:57 Completed build in 13m 55s on Thu, 30 Jul, 09:57 AM Test Summary: 75136 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-734

  9. Sybille Peters commented on patch set 2 07/30/20, 18:08

    > Patch Set 1: > > > Patch Set 1: Verified-1 > > > > Still get message "Page tree error" and JavaScript errors in SvgTree.js line 298: > > I cannot reproduce this issue with the configuration of #91878. What does your setup look like? I can reproduce the new problem: if the user has no access to "Help> About TYPO3 CMS". I think it may be an unrelated problem to this patch (and even the changes before). I just created a stripped down BE user group to test this. Was not intentional
  10. Sven Juergens commented on patch set 2 V +1 07/30/20, 18:34

    Tested and solved the two described Bugs in my TYPO3 9.5.20 installations
  11. Andreas Kienast voted on patch set 2 V +1 CR +1 07/31/20, 06:35

  12. Benny Schimmer voted on patch set 2 V +1 07/31/20, 08:08

  13. Richard Haeser abandoned the change 08/11/20, 12:04

    This will be fixed with the backport of https://review.typo3.org/c/Packages/TYPO3.CMS/+/65208