Review main Merged

65134[BUGFIX] Allow routes without actual route variables for ExtbaseEnhancer

Oliver Hader CR +2 V +2 Easy +3 −1 updated 08/10/20, 10:54

Commit message

The route configuration shown below using `ExtbaseEnhancer` is currently
not evaluated anymore due to missing route variables in `routePath`. For
this particular case in `ExtbaseEnhancer` the controller-action pair is
implicitly defining variables.

MyPlugin:
  type: Extbase
  extension: ...
  plugin: ...
  routes:
    -
      routePath: '/action'
      _controller: 'MyController::action'

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Tiefenbrunn +1
    • Markus Klein +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Tiefenbrunn +1
    • Markus Klein +1
    • Marco Bresch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Oliver Hader uploaded patch set 1 07/28/20, 18:18

  2. TYPO3com voted on patch set 1 V +1 07/28/20, 18:32 Completed build in 13m 33s on Tue, 28 Jul, 06:32 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4288

  3. Markus Klein commented on patch set 1 07/28/20, 19:01

    ExtbasePluginEnhancer.php:152 Unresolved

    this comparison is not necessary I would say.
  4. Markus Klein voted on patch set 1 V +1 07/28/20, 20:22

  5. Marco Bresch commented on patch set 1 V +1 08/06/20, 14:38

    Patch works fine for me. Tested with "f:link.action" and "f:form action"
  6. Georg Tiefenbrunn commented on patch set 1 V +1 CR +1 08/08/20, 16:19

    Also tested with removed condition (-- 149-154, see Markus Klein's comment)
  7. Markus Klein commented on patch set 2 08/10/20, 06:40

    Published edit on patch set 1.
  8. Markus Klein voted on patch set 2 V +1 CR +1 08/10/20, 06:40

  9. TYPO3com voted on patch set 2 V +1 08/10/20, 06:55 Completed build in 14m 46s on Mon, 10 Aug, 06:55 AM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4531

  10. Marco Bresch commented on patch set 2 V +1 08/10/20, 07:32

    Retest of Patchset 2 works fine too. :-)
  11. Georg Tiefenbrunn voted on patch set 2 V +1 CR +1 08/10/20, 07:46

  12. Oliver Hader voted on patch set 2 V +2 CR +2 08/10/20, 10:54

  13. Oliver Hader merged patch set 3 08/10/20, 10:54