Review main Merged

65135[BUGFIX] Add more log info when discarding workspace records fails

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 07/29/20, 07:55

Commit message

Discarding records in the workspace module may lead to
'You do not have edit access' log entries. The issue is hard
to reproduce without the table name and uid in the log.
The patch changes the log entry to contain this info.
This is similar to the log entry change for issue #61719.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Markus Klein +1
    • Simon Gilli +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Markus Klein +1
    • Simon Gilli +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 3

Files 1

Review log 1013

  1. Christian Kuhn uploaded patch set 1 07/28/20, 18:22

  2. Christian Kuhn updated the commit message in patch set 2 07/28/20, 18:23

  3. TYPO3com voted on patch set 1 V +1 07/28/20, 18:34 Completed build in 12m 49s on Tue, 28 Jul, 06:34 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4289

  4. TYPO3com voted on patch set 2 V +1 07/28/20, 18:38 Completed build in 13m 32s on Tue, 28 Jul, 06:38 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4290

  5. Christian Kuhn updated the commit message in patch set 3 07/28/20, 19:23

  6. TYPO3com voted on patch set 3 V +1 07/28/20, 19:36 Completed build in 12m 26s on Tue, 28 Jul, 07:36 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4293

  7. Markus Klein voted on patch set 3 V +1 CR +1 07/28/20, 19:38

  8. Simon Gilli voted on patch set 3 V +1 CR +1 07/28/20, 19:39

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 07/28/20, 19:59

  10. Andreas Kienast commented on patch set 3 V +1 CR +1 07/29/20, 05:53

    DataHandlerHook.php:964

    Maybe add the information here as well?
  11. Christian Kuhn commented on patch set 3 07/29/20, 07:51

    DataHandlerHook.php:964 Reply Unresolved

    this is done with https://review.typo3.org/c/Packages/TYPO3.CMS/+/65132 that fixes a real issue at the same time.
  12. Benni Mack voted on patch set 3 V +2 CR +2 07/29/20, 07:55

  13. Benni Mack merged patch set 4 07/29/20, 07:55