Review main Merged

65136[BUGFIX] Discard only workspace records if deleting workspace

Christian Kuhn CR +2 V +2 Normal +199 −6 updated 07/31/20, 14:48

Commit message

Deleting a sys_workspace record currently fetches all live
records as to-delete candidates while only records of the
according workspace should be considered.
Luckily, a check at a later point prevents live records from
being deleted, though. The huge amount of records however stresses
DataHandler and database a lot.
This is a regression of the 'pid -1 gone' patch from a
broken database restriction.
The patch fixes the where clause and adds a functional test
to verify correct records are deleted.
Two todos in the test csv mark inconsistent details, those
could be handled with a different patch that should
review and increase test scenario coverage of version_WSID() first.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 1014

  1. Christian Kuhn uploaded patch set 1 07/28/20, 19:12

  2. Christian Kuhn updated the commit message in patch set 2 07/28/20, 19:13

  3. Christian Kuhn voted on patch set 2 CR -1 07/28/20, 19:14

  4. TYPO3com voted on patch set 1 V +1 07/28/20, 19:25 Completed build in 12m 17s on Tue, 28 Jul, 07:25 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4291

  5. TYPO3com voted on patch set 2 V +1 07/28/20, 19:28 Completed build in 14m 08s on Tue, 28 Jul, 07:28 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4292

  6. Benni Mack commented on patch set 2 07/29/20, 07:58

    DataHandlerHook.php:1060

    I'm very much in favor of writing the SQL query plain without the workspace restriction, to understand the impact of this query directly.
  7. Christian Kuhn commented on patch set 2 07/29/20, 09:09

    DataHandlerHook.php:1060 Reply Unresolved

    Yeah. This will make it much more straight in this case. Will do.
  8. Christian Kuhn uploaded patch set 3 07/29/20, 11:34

  9. TYPO3com voted on patch set 3 V -1 07/29/20, 11:45 Completed build in 11m 22s on Wed, 29 Jul, 11:45 AM Test Summary: 72927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4301

  10. Christian Kuhn uploaded patch set 4 07/29/20, 13:31

  11. TYPO3com voted on patch set 4 V +1 07/29/20, 13:43 Completed build in 11m 55s on Wed, 29 Jul, 01:43 PM Test Summary: 72927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4304

  12. Benni Mack voted on patch set 4 V +1 CR +1 07/29/20, 19:10

  13. Andreas Kienast voted on patch set 4 V +2 CR +2 07/31/20, 14:48

  14. Andreas Kienast merged patch set 5 07/31/20, 14:48