65136[BUGFIX] Discard only workspace records if deleting workspace
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 2
Files 4
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php2+13 −6
- typo3/sysext/workspaces/Tests/Functional/Hook/DataSet/deletingSysWorkspaceDeletesWorkspaceRecords.csvnew+20 −0
- typo3/sysext/workspaces/Tests/Functional/Hook/DataSet/deletingSysWorkspaceDeletesWorkspaceRecordsResult.csvnew+25 −0
- typo3/sysext/workspaces/Tests/Functional/Hook/DataHandlerHookTest.phpnew+141 −0
Review log 1014
-
Christian Kuhn uploaded patch set 1 07/28/20, 19:12
-
Christian Kuhn updated the commit message in patch set 2 07/28/20, 19:13
-
Christian Kuhn voted on patch set 2 CR -1 07/28/20, 19:14
-
TYPO3com voted on patch set 1 V +1 07/28/20, 19:25 Completed build in 12m 17s on Tue, 28 Jul, 07:25 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4291
-
TYPO3com voted on patch set 2 V +1 07/28/20, 19:28 Completed build in 14m 08s on Tue, 28 Jul, 07:28 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4292
-
Benni Mack commented on patch set 2 07/29/20, 07:58
-
Christian Kuhn commented on patch set 2 07/29/20, 09:09
DataHandlerHook.php:1060Reply UnresolvedYeah. This will make it much more straight in this case. Will do. -
Christian Kuhn uploaded patch set 3 07/29/20, 11:34
-
TYPO3com voted on patch set 3 V -1 07/29/20, 11:45 Completed build in 11m 22s on Wed, 29 Jul, 11:45 AM Test Summary: 72927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4301
-
Christian Kuhn uploaded patch set 4 07/29/20, 13:31
-
TYPO3com voted on patch set 4 V +1 07/29/20, 13:43 Completed build in 11m 55s on Wed, 29 Jul, 01:43 PM Test Summary: 72927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4304
-
Benni Mack voted on patch set 4 V +1 CR +1 07/29/20, 19:10
-
Andreas Kienast voted on patch set 4 V +2 CR +2 07/31/20, 14:48
-
Andreas Kienast merged patch set 5 07/31/20, 14:48
DataHandlerHook.php:1060