65137[BUGFIX] Ensure decoded parameters are a valid array
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oliver Klee +1
- Stefan P +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oliver Hader +2
- Stefan P +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1213
-
Oli Bartsch uploaded patch set 1 07/29/20, 07:40
-
Oliver Hader voted on patch set 1 CR +1 07/29/20, 07:46
-
Stefan P voted on patch set 1 V +1 CR +1 07/29/20, 07:48
-
TYPO3com voted on patch set 1 V +1 07/29/20, 07:52 Completed build in 11m 23s on Wed, 29 Jul, 07:52 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4295
-
Oliver Klee voted on patch set 1 CR +1 07/31/20, 17:39
-
Oliver Klee wrote 07/31/20, 17:39
Removed reviewer Oliver Klee with the following votes: * Code-Review+1 by Oliver Klee <typo3-coding@oliverklee.de> -
Andreas Kienast voted on patch set 1 CR +1 07/31/20, 19:20
-
Oliver Klee voted on patch set 1 CR +1 08/02/20, 22:36
-
Andreas Kienast commented on patch set 1 CR 0 08/05/20, 13:51
ShowImageController.php:137json_decode _may_ return FALSE which will break the foreach as well - should we handle this case as well? -
Andreas Kienast commented on patch set 1 CR +1 08/05/20, 13:55
ShowImageController.php:137Reply UnresolvedNever mind, false is only returned if the payload is constructed as such. -
Oliver Hader commented on patch set 1 V +1 08/10/20, 13:30
I actually wanted to add some tests for this change - however for whatever reason the PHP warnings were "muted" somehow... → https://review.typo3.org/c/Packages/TYPO3.CMS/+/65240/1/typo3/sysext/frontend/Tests/Functional/Controller/ShowImageControllerTest.php as a separate change then -
Oliver Hader voted on patch set 1 V +2 CR +2 08/10/20, 13:31
-
Oliver Hader merged patch set 2 08/10/20, 13:31