Review main Abandoned

65138[BUGFIX] Debounce page tree filtering

Andreas Kienast CR 0 V 0 Easy +5 −6 updated 08/10/20, 09:49

Commit message

The page tree now applies its filter debounced after 250ms which removes
the requirement to press the "Enter" key to improve the page tree UX
again.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 1014

  1. Andreas Kienast uploaded patch set 1 07/29/20, 11:07

  2. Andreas Kienast commented on patch set 1 07/29/20, 11:10

    !! IMPORTANT !! TYPO3/CMS/Core/Event/DebounceEvent does not exist in v9, so have to implement its basic logic in the page tree.
  3. TYPO3com voted on patch set 1 V +1 07/29/20, 11:19 Completed build in 11m 19s on Wed, 29 Jul, 11:19 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4299

  4. Richard Haeser commented on patch set 1 07/29/20, 11:21

    Please test this in installs with over 50.000 pages in page tree. I’m a fan of automatic filtering but please do check it. I can test it on Saturday if needed
  5. Andreas Kienast uploaded patch set 2 07/29/20, 11:22

  6. Andreas Kienast commented on patch set 2 07/29/20, 11:22

    > Patch Set 1: > > Please test this in installs with over 50.000 pages in page tree. I’m a fan of automatic filtering but please do check it. I can test it on Saturday if needed That would be great, I have no such large setup at hand.
  7. Richard Haeser commented on patch set 2 07/29/20, 11:27

    > Patch Set 2: > > > Patch Set 1: > > > > Please test this in installs with over 50.000 pages in page tree. I’m a fan of automatic filtering but please do check it. I can test it on Saturday if needed > > That would be great, I have no such large setup at hand. Will do!
  8. TYPO3com voted on patch set 2 V +1 07/29/20, 11:33 Completed build in 11m 15s on Wed, 29 Jul, 11:33 AM Test Summary: 72923 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4300

  9. Oliver Hader commented on patch set 2 07/29/20, 11:44

    PageTreeToolbar.js:204 Unresolved

    that was flaky before, but I'd prefer either scope binding `delegateFunction.bind(_this)` or arrow functions `(evt) => _this.search(searchInput)`
  10. Andreas Kienast uploaded patch set 3 07/29/20, 12:35

  11. TYPO3com voted on patch set 3 V +1 07/29/20, 12:48 Completed build in 12m 54s on Wed, 29 Jul, 12:48 PM Test Summary: 72923 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4302

  12. Andreas Kienast updated the commit message in patch set 4 07/30/20, 07:41

  13. TYPO3com voted on patch set 4 V +1 07/30/20, 07:54 Completed build in 12m 26s on Thu, 30 Jul, 07:54 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4307

  14. Andreas Kienast abandoned the change 08/10/20, 09:49