Review main Merged

65139[BUGFIX] Properly return integer within resolvePreviewRecordId

Daniel Siepmann CR +2 V +2 Easy +2 −2 updated 07/31/20, 14:37

Commit message

As data is fetched from database, it might not be of proper types, e.g.
when using sqlite.
Therefore ensure returned value is of expected type.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Daniel Siepmann uploaded patch set 1 07/30/20, 06:28

  2. TYPO3com voted on patch set 1 V -1 07/30/20, 06:29 Completed build in 25s on Thu, 30 Jul, 06:29 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4305

  3. Daniel Siepmann uploaded patch set 2 07/30/20, 06:32

  4. TYPO3com voted on patch set 2 V +1 07/30/20, 06:44 Completed build in 11m 41s on Thu, 30 Jul, 06:44 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4306

  5. Oli Bartsch commented on patch set 2 07/30/20, 08:50

    Unresolved

    10.4 and should we also backport to 9.5?
  6. Daniel Siepmann updated the commit message in patch set 3 07/30/20, 10:19

  7. TYPO3com voted on patch set 3 V +1 07/30/20, 10:31 Completed build in 12m 10s on Thu, 30 Jul, 10:31 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4309

  8. Oliver Klee voted on patch set 3 CR +1 07/30/20, 10:33

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 07/30/20, 23:22

  10. Oli Bartsch voted on patch set 3 CR +1 07/31/20, 05:52

  11. Andreas Kienast voted on patch set 3 V +2 CR +2 07/31/20, 14:37

  12. Andreas Kienast merged patch set 4 07/31/20, 14:37