Review main Merged

65142[TASK] Update example of FormProtectionFactory validation

TYPO3com CR +2 V +2 Easy +3 −2 updated 07/31/20, 19:51

Commit message

The example of how to use the FormProtectionFactory in frontend context
uses non-matching arguments making the whole code example harder to
understand.

This patch adjusts the ReST document to use the same arguments in
validateToken() as in generateToken() to make the connection to these
methods more clear.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 69

  1. TYPO3com uploaded patch set 1 07/30/20, 08:44

  2. TYPO3com voted on patch set 1 V +1 07/30/20, 08:56 Completed build in 11m 48s on Thu, 30 Jul, 08:56 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4308

  3. Anja Leichsenring commented on patch set 1 CR -1 07/30/20, 21:05

    this really needs some love
  4. Andreas Kienast updated the commit message in patch set 2 07/31/20, 19:18

  5. TYPO3com voted on patch set 2 V +1 07/31/20, 19:30 Completed build in 12m 00s on Fri, 31 Jul, 07:30 PM Test Summary: 73002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4344

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 07/31/20, 19:38

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 07/31/20, 19:45

  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 07/31/20, 19:51

  9. Anja Leichsenring merged patch set 3 07/31/20, 19:51