Review main Abandoned

65143[BUGFIX] Do not override WHERE clauses in filtered page tree

Andreas Kienast CR 0 V 0 Easy +2 −4 updated 08/10/20, 09:48

Commit message

PageTreeRepository::fetchFilteredTree() wants to apply multiple WHERE
clauses to the QueryBuilder object. This is accidentally done by using
->where() multiple times which will override all previously set
conditions.

This patch changes the code to apply both conditions in the same
->where() call.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 810

  1. Andreas Kienast uploaded patch set 1 07/30/20, 10:29

  2. Andreas Kienast uploaded patch set 2 07/30/20, 10:31

  3. TYPO3com voted on patch set 1 V +1 07/30/20, 10:42 Completed build in 12m 16s on Thu, 30 Jul, 10:42 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4310

  4. TYPO3com voted on patch set 2 V +1 07/30/20, 10:44 Completed build in 13m 16s on Thu, 30 Jul, 10:44 AM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4311

  5. Oliver Hader voted on patch set 2 CR +1 07/30/20, 10:58

  6. Sybille Peters voted on patch set 2 V +1 CR +1 07/30/20, 17:48

  7. Michael Telgkamp voted on patch set 2 V +1 CR +1 07/31/20, 06:22

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 07/31/20, 09:04

  9. Guido Schmechel voted on patch set 2 CR +1 08/06/20, 09:29

  10. Andreas Kienast abandoned the change 08/10/20, 09:48