Review main Merged Breaking

65145[!!!][TASK] Remove t3ver_count and t3ver_tstamp db fields

Benni Mack CR +2 V +2 Hard +116 −242 updated 08/03/20, 17:55

Commit message

The patch drops handling and existence of two further
workspaces related db fields:

* t3ver_tstamp has been occassionally set to 'now' when
records in a workspaces were edited. However, the field
was never displayed in the backend and is of little use
since it only holds only a 'last' value. A change
history on workspace records is available through the
'info' button in the workspace module. This is powered
by sys_history and shows modifications with date/time.

* t3ver_count is also never rendered in the backend. It
has been used in the (non-default) 'swap' workspace actions
where live records become the new workspace records. The
field was then incremented by one. The loose wording around
that is, it's an 'archived' record. However, if swapping a
second time, the workspace record does not count two as one
would expect, but still one. Only after another swap, the
workspace record would have the value two in this field.
Together with the fact this field has never been shown/used,
the weird behavior, and that swapping is an uncommon case
that needs to be explicitely enabled and used, the field
is dropped now.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 20

Review log 710

  1. Benni Mack uploaded patch set 1 07/30/20, 15:07

  2. TYPO3com voted on patch set 1 V -1 07/30/20, 15:19 Completed build in 11m 49s on Thu, 30 Jul, 03:19 PM Test Summary: 3 of 73399 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4315

  3. Christian Kuhn uploaded patch set 2 08/03/20, 16:15

  4. TYPO3com voted on patch set 2 V +1 08/03/20, 16:26 Completed build in 10m 54s on Mon, 3 Aug, 04:26 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4381

  5. Christian Kuhn uploaded patch set 3 08/03/20, 17:32

  6. Christian Kuhn commented on patch set 3 08/03/20, 17:39

    WorkspaceService.php:170 Unresolved

    this is a drive-by change: the nested if with the same condition was obsolete.

    WorkspaceService.php:243 Unresolved

    changing this method signature is not considered breaking due to 'internal' ext:workspace service.

    WorkspaceServiceTest.php:48 Unresolved

    enabling this test again since it actually makes kinda sense ...

    WorkspaceServiceTest.php:141 Unresolved

    this one is obsolete with the removal of t3ver_count.
  7. TYPO3com voted on patch set 3 V +1 08/03/20, 17:44 Completed build in 11m 31s on Mon, 3 Aug, 05:44 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4382

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 08/03/20, 17:46

  9. Anja Leichsenring voted on patch set 3 V +2 CR +2 08/03/20, 17:55

  10. Anja Leichsenring merged patch set 4 08/03/20, 17:55