Review main Merged

65146[BUGFIX] Tests for translated content will prepare a translated page

Anja Leichsenring CR +2 V +2 Easy +42 −4 updated 08/03/20, 10:33

Commit message

Language handling always bases on the existence of a page version for
the requested language. If this is not available, handling follows
fallback settings.

Functional Tests that test for translated content to be returned
as expected must provide such a translated page on their own, else
the fallback handling kicks in, renders the test falsly reassuring.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 914

  1. Anja Leichsenring uploaded patch set 1 07/30/20, 18:39

  2. TYPO3com voted on patch set 1 V +1 07/30/20, 18:51 Completed build in 11m 57s on Thu, 30 Jul, 06:51 PM Test Summary: 72924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4316

  3. Anja Leichsenring commented on patch set 1 V -1 07/30/20, 19:26

    not yet done, same procedure in workspaces tests.
  4. Anja Leichsenring uploaded patch set 2 07/31/20, 16:28

  5. TYPO3com voted on patch set 2 V -1 07/31/20, 16:40 Completed build in 12m 10s on Fri, 31 Jul, 04:40 PM Test Summary: 3 of 73492 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4340

  6. Anja Leichsenring uploaded patch set 3 07/31/20, 16:59

  7. TYPO3com voted on patch set 3 V -1 07/31/20, 17:11 Completed build in 11m 08s on Fri, 31 Jul, 05:10 PM Test Summary: 3 of 73492 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4341

  8. Anja Leichsenring uploaded patch set 4 07/31/20, 17:35

  9. TYPO3com voted on patch set 4 V -1 07/31/20, 17:47 Completed build in 11m 08s on Fri, 31 Jul, 05:47 PM Test Summary: 3 of 73492 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4342

  10. Anja Leichsenring uploaded patch set 5 07/31/20, 17:54

  11. TYPO3com voted on patch set 5 V +1 07/31/20, 18:06 Completed build in 11m 28s on Fri, 31 Jul, 06:06 PM Test Summary: 73005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4343

  12. Christian Kuhn voted on patch set 5 V +1 CR +1 07/31/20, 18:06

  13. Benni Mack voted on patch set 5 V +2 CR +2 08/03/20, 10:33

  14. Benni Mack merged patch set 6 08/03/20, 10:33