65147[!!!][TASK] Move sys_collection_* DB and TCA definitions into legacy_collections
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 14
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php1+19 −11
- typo3/sysext/core/Classes/Collection/RecordCollectionRepository.phpdeleted+0 −234
- typo3/sysext/core/Classes/Collection/StaticRecordCollection.phpdeleted+0 −198
- typo3/sysext/core/Classes/Resource/FileCollectionRepository.php+108 −4
- typo3/sysext/core/Configuration/TCA/sys_collection.phpdeleted+0 −195
- typo3/sysext/core/Documentation/Changelog/master/Breaking-91909-SysCollectionDatabaseTablesMovedIntoExternalExtension.rstnew+57 −0
- typo3/sysext/core/Resources/Private/Language/locallang_tca.xlf+0 −21
- typo3/sysext/core/Tests/Functional/Collection/RecordCollectionRepositoryTest.phpdeleted+0 −333
- typo3/sysext/core/Tests/Functional/Tca/CollectionVisibleFieldsTest.phpdeleted+0 −55
- typo3/sysext/core/ext_tables.sql+0 −25
- typo3/sysext/install/Classes/Updates/CollectionsExtractionUpdate.phpnew+141 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+10 −0
- typo3/sysext/install/ext_localconf.php+2 −0
- typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php+0 −1
Review log 1423
-
Benni Mack uploaded patch set 1 07/31/20, 09:34
-
TYPO3com voted on patch set 1 V -1 07/31/20, 09:35 Completed build in 23s on Fri, 31 Jul, 09:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4326
-
Benni Mack uploaded patch set 2 07/31/20, 09:46
-
TYPO3com voted on patch set 2 V -1 07/31/20, 09:58 Completed build in 11m 20s on Fri, 31 Jul, 09:58 AM Test Summary: 3 of 73375 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4327
-
Benni Mack uploaded patch set 3 07/31/20, 10:17
-
TYPO3com voted on patch set 3 V -1 07/31/20, 10:29 Completed build in 11m 59s on Fri, 31 Jul, 10:29 AM Test Summary: 72888 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4328
-
TYPO3com commented on patch set 3 07/31/20, 10:55 Completed build in 50m 05s on Fri, 31 Jul, 10:55 AM Test Summary: 72888 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4328
-
Benni Mack uploaded patch set 4 07/31/20, 11:00
-
TYPO3com voted on patch set 4 V +1 07/31/20, 11:11 Completed build in 11m 09s on Fri, 31 Jul, 11:11 AM Test Summary: 72888 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4330
-
Andreas Kienast commented on patch set 4 07/31/20, 11:15
-
Benni Mack commented on patch set 5 07/31/20, 13:47
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V +1 07/31/20, 14:00 Completed build in 12m 32s on Fri, 31 Jul, 02:00 PM Test Summary: 72888 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4333
-
Christian Kuhn uploaded patch set 6 08/03/20, 10:19
-
Christian Kuhn commented on patch set 6 V +1 CR +1 08/03/20, 10:23
* codewise review * tested creating a sys_collection with items on pid 0 without patch * created a sys_file_collection on same page and verified rendering of a file links tt_content element pointing to that file collection works without patch * applied patch, verified the tt_content record is still rendered, also breakpointing the code in FileCollectionRepository * install 'legacy_collection' via new upgrade wizard, verify the sys_collection record on pid 0 shown up again. -> looks good to me overally. -
TYPO3com voted on patch set 6 V +1 08/03/20, 10:31 Completed build in 11m 46s on Mon, 3 Aug, 10:31 AM Test Summary: 72966 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4370
-
Anja Leichsenring updated the commit message in patch set 7 08/03/20, 11:14
-
Anja Leichsenring commented on patch set 8 08/03/20, 11:20
Published edit on patch set 7. -
Anja Leichsenring voted on patch set 8 V +1 CR +1 08/03/20, 11:21
-
Christian Kuhn voted on patch set 8 V +1 CR +1 08/03/20, 11:26
-
TYPO3com voted on patch set 7 V +1 08/03/20, 11:27 Completed build in 12m 28s on Mon, 3 Aug, 11:27 AM Test Summary: 72969 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4374
-
TYPO3com voted on patch set 8 V +1 08/03/20, 11:31 Completed build in 11m 30s on Mon, 3 Aug, 11:31 AM Test Summary: 72969 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4375
-
Anja Leichsenring voted on patch set 8 V +2 CR +2 08/03/20, 11:32
-
Anja Leichsenring merged patch set 9 08/03/20, 11:32
AbstractRecordCollection.php:444Unresolved