Review main Merged Breaking

65147[!!!][TASK] Move sys_collection_* DB and TCA definitions into legacy_collections

Benni Mack CR +2 V +2 Expert +337 −1077 updated 08/03/20, 11:32

Commit message

A new TER Extension "legacy_collections" has been added to FriendsOfTYPO3
which contains DB tables and TCA definitions for "sys_collection" and its MM
relation table.

The functionality was originally intended with the introduction of taxonomy
and FAL File relations (which are stored in sys_file_collection) to be used
as a generic TCA store for collections, which was never picked up in the past
8 years.

A personal survey of several installations showed that almost none of the TYPO3
instances have the database tables filled, making this unneeded code
and database code, for only a handful of people.

Instead of providing the database tables by default in all installations, the
database tables and their TCA definitions are now available in a separate
extension "legacy_collections", which serves as a drop-in replacement
for everybody who needs this API and the database tables.

An update wizard checks if the sys_collection database table is filled,
and allows to install this extension.

The new extension is compatible with TYPO3 v10, so it should ease
the migration path.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 1423

  1. Benni Mack uploaded patch set 1 07/31/20, 09:34

  2. TYPO3com voted on patch set 1 V -1 07/31/20, 09:35 Completed build in 23s on Fri, 31 Jul, 09:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4326

  3. Benni Mack uploaded patch set 2 07/31/20, 09:46

  4. TYPO3com voted on patch set 2 V -1 07/31/20, 09:58 Completed build in 11m 20s on Fri, 31 Jul, 09:58 AM Test Summary: 3 of 73375 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4327

  5. Benni Mack uploaded patch set 3 07/31/20, 10:17

  6. TYPO3com voted on patch set 3 V -1 07/31/20, 10:29 Completed build in 11m 59s on Fri, 31 Jul, 10:29 AM Test Summary: 72888 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4328

  7. TYPO3com commented on patch set 3 07/31/20, 10:55 Completed build in 50m 05s on Fri, 31 Jul, 10:55 AM Test Summary: 72888 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4328

  8. Benni Mack uploaded patch set 4 07/31/20, 11:00

  9. TYPO3com voted on patch set 4 V +1 07/31/20, 11:11 Completed build in 11m 09s on Fri, 31 Jul, 11:11 AM Test Summary: 72888 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4330

  10. Andreas Kienast commented on patch set 4 07/31/20, 11:15

    AbstractRecordCollection.php:444 Unresolved

    maybe `'defined in ' . static::class`?
  11. Benni Mack commented on patch set 5 07/31/20, 13:47

    Published edit on patch set 4.
  12. TYPO3com voted on patch set 5 V +1 07/31/20, 14:00 Completed build in 12m 32s on Fri, 31 Jul, 02:00 PM Test Summary: 72888 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4333

  13. Christian Kuhn uploaded patch set 6 08/03/20, 10:19

  14. Christian Kuhn commented on patch set 6 V +1 CR +1 08/03/20, 10:23

    * codewise review * tested creating a sys_collection with items on pid 0 without patch * created a sys_file_collection on same page and verified rendering of a file links tt_content element pointing to that file collection works without patch * applied patch, verified the tt_content record is still rendered, also breakpointing the code in FileCollectionRepository * install 'legacy_collection' via new upgrade wizard, verify the sys_collection record on pid 0 shown up again. -> looks good to me overally.
  15. TYPO3com voted on patch set 6 V +1 08/03/20, 10:31 Completed build in 11m 46s on Mon, 3 Aug, 10:31 AM Test Summary: 72966 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4370

  16. Anja Leichsenring updated the commit message in patch set 7 08/03/20, 11:14

  17. Anja Leichsenring commented on patch set 8 08/03/20, 11:20

    Published edit on patch set 7.
  18. Anja Leichsenring voted on patch set 8 V +1 CR +1 08/03/20, 11:21

  19. Christian Kuhn voted on patch set 8 V +1 CR +1 08/03/20, 11:26

  20. TYPO3com voted on patch set 7 V +1 08/03/20, 11:27 Completed build in 12m 28s on Mon, 3 Aug, 11:27 AM Test Summary: 72969 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4374

  21. TYPO3com voted on patch set 8 V +1 08/03/20, 11:31 Completed build in 11m 30s on Mon, 3 Aug, 11:31 AM Test Summary: 72969 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4375

  22. Anja Leichsenring voted on patch set 8 V +2 CR +2 08/03/20, 11:32

  23. Anja Leichsenring merged patch set 9 08/03/20, 11:32