Review main Abandoned

65148[WIP][TASK] Provide acceptance tests for page tree filter

Anja Leichsenring CR 0 V 0 Normal +131 −13 updated 08/12/20, 15:16

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 3360

Show 1835 earlier messages
  1. Anja Leichsenring uploaded patch set 1 08/01/20, 14:38

  2. Anja Leichsenring uploaded patch set 2 08/01/20, 14:39

  3. TYPO3com voted on patch set 1 V -1 08/01/20, 14:39 Completed build in 27s on Sat, 1 Aug, 02:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4347

  4. TYPO3com commented on patch set 2 08/01/20, 14:39 Completed build in 23s on Sat, 1 Aug, 02:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4348

  5. Anja Leichsenring commented on patch set 2 08/01/20, 14:42

    some remarks here: - this patch was made with commit 9dc190ada6, that was one before the page tree speed up patch. - it fails even there, because, we got a problem already at this stage. We need to agree on way to handle things - I did not include the missing notify box that indicates the filter mode is active. It was lost earlier - the target versions match the targets the page tree speed up test was merged to Let's talk how to move forward, I appreciate all your feedback!
  6. Anja Leichsenring uploaded patch set 3 08/01/20, 14:42

  7. Anja Leichsenring updated the commit message in patch set 4 08/01/20, 14:49

  8. TYPO3com voted on patch set 3 V -1 08/01/20, 14:55 Completed build in 13m 04s on Sat, 1 Aug, 02:55 PM Test Summary: 1 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4349

  9. TYPO3com voted on patch set 4 V -1 08/01/20, 15:01 Completed build in 12m 08s on Sat, 1 Aug, 03:01 PM Test Summary: 1 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4350

  10. Anja Leichsenring uploaded patch set 5 08/01/20, 15:02

  11. TYPO3com voted on patch set 5 V -1 08/01/20, 15:03 Completed build in 22s on Sat, 1 Aug, 03:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4351

  12. Anja Leichsenring uploaded patch set 6 08/01/20, 15:05

  13. Anja Leichsenring updated the commit message in patch set 7 08/01/20, 15:16

  14. TYPO3com voted on patch set 6 V -1 08/01/20, 15:16 Completed build in 11m 08s on Sat, 1 Aug, 03:16 PM Test Summary: 1 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4352

  15. Anja Leichsenring uploaded patch set 8 08/01/20, 15:22

  16. TYPO3com voted on patch set 7 V -1 08/01/20, 15:27 Completed build in 11m 41s on Sat, 1 Aug, 03:27 PM Test Summary: 1 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4353

  17. Anja Leichsenring uploaded patch set 9 08/01/20, 15:28

  18. TYPO3com voted on patch set 8 V -1 08/01/20, 15:34 Completed build in 11m 55s on Sat, 1 Aug, 03:34 PM Test Summary: 1 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4354

  19. Anja Leichsenring uploaded patch set 10 08/01/20, 15:35

  20. Anja Leichsenring uploaded patch set 11 08/01/20, 15:39

  21. TYPO3com voted on patch set 9 V -1 08/01/20, 15:40 Completed build in 11m 59s on Sat, 1 Aug, 03:40 PM Test Summary: 1 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4355

  22. Anja Leichsenring uploaded patch set 12 08/01/20, 15:49

  23. TYPO3com commented on patch set 10 08/01/20, 15:50 Completed build in 14m 07s on Sat, 1 Aug, 03:49 PM Test Summary: 1 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4356

  24. TYPO3com voted on patch set 11 V -1 08/01/20, 15:52 Completed build in 13m 19s on Sat, 1 Aug, 03:52 PM Test Summary: 1 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4357

  25. Anja Leichsenring uploaded patch set 13 08/01/20, 15:54

  26. TYPO3com voted on patch set 12 V -1 08/01/20, 16:00 Completed build in 11m 28s on Sat, 1 Aug, 04:00 PM Test Summary: 1 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4358

  27. Anja Leichsenring uploaded patch set 14 08/01/20, 16:02

  28. TYPO3com voted on patch set 13 V -1 08/01/20, 16:06 Completed build in 11m 37s on Sat, 1 Aug, 04:06 PM Test Summary: 2 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4359

  29. TYPO3com voted on patch set 14 V +1 08/01/20, 16:15 Completed build in 11m 56s on Sat, 1 Aug, 04:14 PM Test Summary: 73002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4360

  30. Anja Leichsenring uploaded patch set 15 08/01/20, 16:22

  31. TYPO3com voted on patch set 15 V +1 08/01/20, 16:34 Completed build in 11m 01s on Sat, 1 Aug, 04:34 PM Test Summary: 73002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4361

  32. Anja Leichsenring uploaded patch set 16 08/01/20, 17:09

  33. TYPO3com voted on patch set 16 V -1 08/01/20, 17:20 Completed build in 11m 16s on Sat, 1 Aug, 05:20 PM Test Summary: 2 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4362

  34. TYPO3com commented on patch set 16 08/01/20, 17:26 Completed build in 28m 17s on Sat, 1 Aug, 05:26 PM Test Summary: 2 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4362

  35. Anja Leichsenring uploaded patch set 17 08/01/20, 17:27

  1. TYPO3com voted on patch set 17 V -1 08/01/20, 17:38 Completed build in 11m 14s on Sat, 1 Aug, 05:38 PM Test Summary: 2 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4363

  2. Anja Leichsenring uploaded patch set 18 08/01/20, 17:49

  3. Anja Leichsenring uploaded patch set 19 08/01/20, 17:59

  4. TYPO3com voted on patch set 18 V -1 08/01/20, 18:01 Completed build in 12m 35s on Sat, 1 Aug, 06:01 PM Test Summary: 2 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4364

  5. Anja Leichsenring uploaded patch set 20 08/01/20, 18:06

  6. TYPO3com voted on patch set 19 V -1 08/01/20, 18:11 Completed build in 12m 10s on Sat, 1 Aug, 06:11 PM Test Summary: 2 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4365

  7. TYPO3com voted on patch set 20 V -1 08/01/20, 18:18 Completed build in 11m 46s on Sat, 1 Aug, 06:18 PM Test Summary: 3 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4366

  8. Anja Leichsenring uploaded patch set 21 08/01/20, 18:21

  9. Anja Leichsenring commented on patch set 21 08/01/20, 18:29

    some remarks here: - this patch was made with commit 9dc190ada6, that was one before the page tree speed up patch. - it fails even there, because, we got a problem already at this stage. We need to agree on way to handle things (you can see that in the red test in bamboo and my comments in PageTreeFilterCest.php - I did not include the missing notify box that indicates the filter mode is active. It was lost earlier the target versions match the targets the page tree speed up test was merged to Let's talk how to move forward, I appreciate all your feedback!
  10. TYPO3com voted on patch set 21 V -1 08/01/20, 18:32 Completed build in 11m 26s on Sat, 1 Aug, 06:32 PM Test Summary: 1 of 73490 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4367

  11. Benni Mack commented on patch set 21 08/03/20, 20:24

    YamlFileLoader.php:139

    why would you need this change? getFileAbsFileName() should do the trick already?
  12. Anja Leichsenring uploaded patch set 22 08/04/20, 16:28

  13. Anja Leichsenring uploaded patch set 23 08/04/20, 16:31

  14. Anja Leichsenring commented on patch set 23 08/04/20, 16:32

    YamlFileLoader.php:139 Reply

    it did not during my test setup, but does now. This change has been reverted.
  15. TYPO3com voted on patch set 22 V -1 08/04/20, 16:40 Completed build in 11m 51s on Tue, 4 Aug, 04:40 PM Test Summary: 1 of 73442 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4406

  16. TYPO3com voted on patch set 23 V -1 08/04/20, 16:44 Completed build in 12m 32s on Tue, 4 Aug, 04:44 PM Test Summary: 1 of 73442 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4407

  17. Anja Leichsenring updated the commit message in patch set 24 08/07/20, 11:47

  18. TYPO3com voted on patch set 24 V -1 08/07/20, 12:11 Completed build in 13m 39s on Fri, 7 Aug, 12:11 PM Test Summary: 1 of 73468 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4471

  19. Frank Nägler commented on patch set 24 08/07/20, 12:33

    PageTreeFilterCest.php:40 Unresolved

    I would use a variable for the repeating selectors, e.g. $toolbarElementSelector = '#typo3-pagetree #svg-toolbar '; ... $I->cantSeeElement(toolbarElementSelector . 'span[data-identifier=actions-close]'); ... This makes later adjustments easier but also the review process.
  20. Anja Leichsenring uploaded patch set 25 08/08/20, 14:26

  21. TYPO3com voted on patch set 25 V -1 08/08/20, 14:26 Completed build in 24s on Sat, 8 Aug, 02:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4502

  22. Anja Leichsenring uploaded patch set 26 08/08/20, 14:27

  23. Claus Due voted on patch set 26 CR +1 08/08/20, 14:33

  24. TYPO3com voted on patch set 26 V -1 08/08/20, 14:39 Completed build in 11m 37s on Sat, 8 Aug, 02:39 PM Test Summary: 1 of 73456 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4503

  25. Anja Leichsenring abandoned the change 08/12/20, 15:16