Review main Merged

65151[BUGFIX] Rename default storage from "fileadmin/ (auto-created)" to "fileadmin"

Benni Mack CR +2 V +2 Normal +43 −43 updated 08/03/20, 18:04

Commit message

The information in the sys_file_storage record created automatically
should not be persisted as "auto-created" as 90% of the people do not
modify this, and it is only confusing to see this information in the filelist
without having a good and explained way to change this.

Instead "fileadmin" (taken from $GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'])
is used when creating the default storage.

This was originally added by myself when introducing FAL in 6.0,
and never touched, however feedback from newcomers shows that
this should be adapted.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 28

Show 8 more files

Review log 68

  1. Benni Mack uploaded patch set 1 08/03/20, 10:21

  2. TYPO3com voted on patch set 1 V +1 08/03/20, 10:36 Completed build in 14m 21s on Mon, 3 Aug, 10:36 AM Test Summary: 73002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4371

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 08/03/20, 10:47

  4. Benni Mack updated the commit message in patch set 2 08/03/20, 11:26

  5. TYPO3com voted on patch set 2 V +1 08/03/20, 11:37 Completed build in 11m 23s on Mon, 3 Aug, 11:37 AM Test Summary: 73005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4376

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 08/03/20, 18:02

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/03/20, 18:04

  8. Anja Leichsenring merged patch set 3 08/03/20, 18:04