Review 10.4 Merged

65153[BUGFIX] Discard only workspace records if deleting workspace

Andreas Kienast CR +2 V +2 Normal +199 −6 updated 07/31/20, 15:06

Commit message

Deleting a sys_workspace record currently fetches all live
records as to-delete candidates while only records of the
according workspace should be considered.
Luckily, a check at a later point prevents live records from
being deleted, though. The huge amount of records however stresses
DataHandler and database a lot.
This is a regression of the 'pid -1 gone' patch from a
broken database restriction.
The patch fixes the where clause and adds a functional test
to verify correct records are deleted.
Two todos in the test csv mark inconsistent details, those
could be handled with a different patch that should
review and increase test scenario coverage of version_WSID() first.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 34

  1. Andreas Kienast commented on patch set 1 07/31/20, 14:49

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 07/31/20, 15:01 Completed build in 12m 14s on Fri, 31 Jul, 03:01 PM Test Summary: 73992 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-141

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 07/31/20, 15:06

  4. Andreas Kienast merged patch set 2 07/31/20, 15:06