Review 10.4 Merged

65160[BUGFIX] Fetch TYPO3 version in reports module only

Benni Mack CR +2 V +2 Normal +2 −96 updated 08/04/20, 18:17

Commit message

The core version check is run synchronously while logging
into the Backend. If the get.typo3.org service is down,
logins take extremely long.

Since there is no API to run this check asynchronously,
the patch drops this information from the toolbar,
it is only available in the reports module.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1013

  1. Benni Mack commented on patch set 1 08/04/20, 15:01

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/install/Configuration/Services.yaml
  2. TYPO3com voted on patch set 1 V -1 08/04/20, 15:05 Completed build in 04m 04s on Tue, 4 Aug, 03:05 PM Test Summary: 10787 of 74380 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-155

  3. Christian Kuhn uploaded patch set 2 08/04/20, 16:53

  4. TYPO3com voted on patch set 2 V +1 08/04/20, 17:06 Completed build in 12m 31s on Tue, 4 Aug, 05:06 PM Test Summary: 73995 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-156

  5. Christian Kuhn voted on patch set 2 CR -1 08/04/20, 17:14

  6. Christian Kuhn uploaded patch set 3 08/04/20, 17:16

  7. Anja Leichsenring abandoned the change 08/04/20, 17:22

    repush in progress. we can't get rid of the WIP flag here, which was caused by the conflicting cherry-pick.
  8. Anja Leichsenring restored the change 08/04/20, 17:23

  9. TYPO3com voted on patch set 3 V +1 08/04/20, 17:29 Completed build in 12m 43s on Tue, 4 Aug, 05:29 PM Test Summary: 73995 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-157

  10. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/04/20, 18:13

  11. Benni Mack commented on patch set 3 08/04/20, 18:15

    This change is ready for review.
  12. Benni Mack voted on patch set 3 V +2 CR +2 08/04/20, 18:16

  13. Benni Mack merged patch set 4 08/04/20, 18:17