Review main Merged

65181[BUGFIX] Prevent non-numeric value warning in PhpErrorCodeViewHelper

Kevin Ditscheid CR +2 V +2 Easy +1 −1 updated 08/04/20, 18:20

Commit message

This commit prevents a warning regarding a non-numeric value in the
phpErrorCode argument of the PhpErrorCodeViewHelper. TYPO3 Fluid is
actually not converting the value to int, and there could be anything
incoming as parameter.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Kevin Ditscheid uploaded patch set 1 08/04/20, 15:44

  2. TYPO3com voted on patch set 1 V +1 08/04/20, 15:57 Completed build in 12m 46s on Tue, 4 Aug, 03:57 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4404

  3. Oliver Klee updated the commit message in patch set 2 08/04/20, 16:34

  4. Oliver Klee voted on patch set 2 CR +1 08/04/20, 16:35

  5. TYPO3com voted on patch set 2 V +1 08/04/20, 16:55 Completed build in 20m 34s on Tue, 4 Aug, 04:55 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4410

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 08/04/20, 18:06

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/04/20, 18:19

  8. Anja Leichsenring merged patch set 3 08/04/20, 18:20