65184[!!!][TASK] FAL: Decouple logic of ResourceFactory into StorageRepository
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Georg Ringer +1
-
Verified V +2 Done
- Helmut Hummel +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 27
- typo3/sysext/backend/Classes/Form/Element/UserSysFileStorageIsPublicElement.php+2 −2
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php1+16 −41
- typo3/sysext/core/Classes/Resource/Index/Indexer.php+1 −1
- typo3/sysext/core/Classes/Resource/File.php+1 −1
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+1 −1
- typo3/sysext/core/Classes/Resource/ProcessedFileRepository.php1+0 −1
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+32 −200
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+57 −13
- typo3/sysext/core/Classes/Resource/StorageRepository.php1+229 −45
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php1+0 −2
- typo3/sysext/core/Classes/ServiceProvider.php+5 −2
- typo3/sysext/core/Documentation/Changelog/master/Breaking-92289-DecoupleLogicOfResourceFactoryIntoStorageRepository.rstnew+64 −0
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php+5 −99
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+3 −4
- typo3/sysext/core/Tests/Unit/Resource/StorageRepositoryTest.phpnew+127 −0
- typo3/sysext/filelist/Classes/Controller/FileListController.php+3 −4
- typo3/sysext/form/Tests/Functional/Hooks/FormFileExtensionUpdateTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+2 −1
Show 7 more files
- typo3/sysext/frontend/Tests/Functional/SiteHandling/TypoLinkGeneratorTest.php+1 −1
- typo3/sysext/impexp/Classes/Import.php+7 −6
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php+1 −2
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionTask.php+2 −2
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingAdditionalFieldProvider.php+1 −2
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingTask.php+2 −2
Review log 2741
Show 916 earlier messages
-
Benni Mack uploaded patch set 1 08/05/20, 09:19
-
TYPO3com voted on patch set 1 V -1 08/05/20, 09:30 Completed build in 10m 56s on Wed, 5 Aug, 09:30 AM Test Summary: 7682 of 73348 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4414
-
Benni Mack uploaded patch set 2 08/14/20, 20:35
-
TYPO3com voted on patch set 2 V -1 08/14/20, 20:47 Completed build in 11m 42s on Fri, 14 Aug, 08:47 PM Test Summary: 1301 of 68480 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4668
-
Benni Mack uploaded patch set 3 08/31/20, 10:14
-
TYPO3com voted on patch set 3 V -1 08/31/20, 10:28 Completed build in 13m 30s on Mon, 31 Aug, 10:27 AM Test Summary: 2125 of 73631 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5077
-
Benni Mack uploaded patch set 4 08/31/20, 10:59
-
TYPO3com voted on patch set 4 V -1 08/31/20, 11:11 Completed build in 11m 31s on Mon, 31 Aug, 11:11 AM Test Summary: 330 of 73631 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5080
-
Benni Mack uploaded patch set 5 08/31/20, 11:47
-
TYPO3com voted on patch set 5 V -1 08/31/20, 11:58 Completed build in 11m 00s on Mon, 31 Aug, 11:58 AM Test Summary: 72 of 73631 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5083
-
Benni Mack uploaded patch set 6 08/31/20, 12:15
-
TYPO3com voted on patch set 6 V +1 08/31/20, 12:26 Completed build in 11m 00s on Mon, 31 Aug, 12:26 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5084
-
Benni Mack uploaded patch set 7 09/07/20, 09:24
-
TYPO3com voted on patch set 7 V +1 09/07/20, 09:35 Completed build in 11m 26s on Mon, 7 Sep, 09:35 AM Test Summary: 73227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5316
-
Benni Mack uploaded patch set 8 09/11/20, 11:13
-
Benni Mack updated the commit message in patch set 9 09/11/20, 11:14
-
TYPO3com voted on patch set 8 V -1 09/11/20, 11:27 Completed build in 13m 11s on Fri, 11 Sep, 11:27 AM Test Summary: 132 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5538
-
TYPO3com voted on patch set 9 V -1 09/11/20, 11:32 Completed build in 17m 51s on Fri, 11 Sep, 11:32 AM Test Summary: 132 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5539
-
Benni Mack uploaded patch set 10 09/12/20, 17:43
-
TYPO3com voted on patch set 10 V +1 09/12/20, 17:55 Completed build in 12m 20s on Sat, 12 Sep, 05:55 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5560
-
Simon Gilli updated the commit message in patch set 11 09/12/20, 18:51
-
Benjamin Franzke commented on patch set 11 09/12/20, 18:57
@gilbertsort: "god class" is not a typo, it is a judgement ;) The context makes that quite clear… So "good class" is actually wrong now. The preposition "to build" may have been a bit confusing, therefore this may better be: "seems to be a god class that builds"FileIndexRepository.php:126UnresolvedConstructor bases dependency injection (instead of GU:makeInstance) for a new dependency in a singleton please. -
TYPO3com voted on patch set 11 V +1 09/12/20, 19:09 Completed build in 14m 41s on Sat, 12 Sep, 07:09 PM Test Summary: 73208 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5564
-
Benni Mack uploaded patch set 12 09/12/20, 19:11
-
TYPO3com voted on patch set 12 V +1 09/12/20, 19:26 Completed build in 14m 46s on Sat, 12 Sep, 07:26 PM Test Summary: 73208 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5566
-
Simon Gilli voted on patch set 12 CR +1 09/13/20, 09:33
-
Simon Gilli commented on patch set 12 09/13/20, 09:34
Reply
Oops, sorry for that -
Oliver Klee commented on patch set 13 09/13/20, 11:22
Published edit on patch set 12. -
TYPO3com voted on patch set 13 V +1 09/13/20, 11:34 Completed build in 12m 13s on Sun, 13 Sep, 11:34 AM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5577
-
Benni Mack commented on patch set 13 09/14/20, 07:50
Thx, @Oli -
Helmut Hummel commented on patch set 13 09/15/20, 07:37
great cleanupProcessedFileRepository.php:91UnresolvedThat line looks kind of pointless now. Maybe remove it and even deprecate or remove the setter?StorageRepository.php:331Unresolvedthis method can never return null. it is always an object or a fatal error occurs or an exception is thrownExtendedFileUtility.php:1094UnresolvedI guess this line is obsolete, too, don't you think? -
Benni Mack uploaded patch set 14 09/15/20, 11:56
-
TYPO3com voted on patch set 14 V +1 09/15/20, 12:09 Completed build in 13m 00s on Tue, 15 Sep, 12:09 PM Test Summary: 73272 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5627
-
Benni Mack commented on patch set 14 09/15/20, 12:17
> Patch Set 13: > > (3 comments) > > great cleanup @helhum: Thanks for your remarks! Incorporated all the changes. -
Helmut Hummel voted on patch set 14 CR +1 09/28/20, 12:09
-
Georg Ringer commented on patch set 14 09/28/20, 12:36
shouldn't we now deprecate also all methods in resourcefactory which have been moved? -
Benni Mack commented on patch set 14 09/29/20, 06:59
> Patch Set 14: > > shouldn't we now deprecate also all methods in resourcefactory which have been moved? I left them there on purpose (thought it was on the commit message, but it isn't) because the methods do not hurt, so migration can be done over multiple major versions. -
Georg Ringer voted on patch set 14 V +1 CR +1 09/29/20, 08:38
-
Helmut Hummel voted on patch set 14 V +2 CR +2 09/30/20, 13:16
-
Helmut Hummel merged patch set 15 09/30/20, 13:16
-
Benni Mack commented on patch set 15 09/30/20, 14:22
Thank you for your reviews!