Review main Merged

65188[BUGFIX] Allow moving a workspace record after itself

Christian Kuhn CR +2 V +2 Hard +277 −11 updated 08/06/20, 09:08

Commit message

Another 'broken since ever' fix: Sorting a record in
workspaces by moving it 'after itself', the record vanishes
from the interface. While this action is kinda useless,
it can for instance accidently happen by an editor.

As with other move operations in workspaces, a move
placeholder and the versioned data record is created.
In case of inserting after itself, the move placeholder
state is not correctly updated - both pid and sorting
values end up with 0. The records then no longer belong
to the correct pid and are not 'seen' by workspaces.

The patch fixes this case by making sure the pid and sorting
determination of the move placeholder does not accidently
operate on itself as reference record. A series of functional
DataHandler tests nail the correct state for pages and
tt_content in non-workspace and workspace scenarios.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 1216

  1. Christian Kuhn uploaded patch set 1 08/05/20, 13:20

  2. TYPO3com voted on patch set 1 V +1 08/05/20, 13:31 Completed build in 11m 34s on Wed, 5 Aug, 01:31 PM Test Summary: 72960 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4423

  3. Christian Kuhn uploaded patch set 2 08/05/20, 14:28

  4. TYPO3com voted on patch set 2 V +1 08/05/20, 14:39 Completed build in 11m 11s on Wed, 5 Aug, 02:39 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4424

  5. Benni Mack commented on patch set 2 V +1 CR +1 08/05/20, 15:19

    very good catch. One line of change, but lots of tests to it. Thanks a lot for fixing this long-outstanding issue.
  6. Benni Mack updated the commit message in patch set 3 08/05/20, 15:20

  7. Benni Mack voted on patch set 3 V +1 CR +1 08/05/20, 15:20

  8. TYPO3com voted on patch set 3 V +1 08/05/20, 15:31 Completed build in 11m 34s on Wed, 5 Aug, 03:31 PM Test Summary: 72978 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4428

  9. David Steeb voted on patch set 3 CR +1 08/05/20, 15:59

  10. Benni Mack voted on patch set 3 V +2 CR +2 08/05/20, 20:46

  11. Benni Mack voted on patch set 3 V +1 CR +1 08/05/20, 20:46

  12. Anja Leichsenring updated the commit message in patch set 4 08/06/20, 08:46

  13. Anja Leichsenring voted on patch set 4 V +1 CR +1 08/06/20, 08:48

  14. TYPO3com voted on patch set 4 V +1 08/06/20, 08:58 Completed build in 11m 52s on Thu, 6 Aug, 08:58 AM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4434

  15. Benni Mack voted on patch set 4 V +2 CR +2 08/06/20, 09:08

  16. Benni Mack merged patch set 5 08/06/20, 09:08