65189[BUGFIX] Use GeneralUtility::makeInstance instead of ObjectManager calls
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Oliver Klee +1
- Wouter Wolters +1
- Anja Leichsenring +1
- Daniel Haupt +1
-
Verified V +2 Done
- Frank Nägler +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php+1 −4
- typo3/sysext/form/Classes/Domain/Finishers/FinisherContext.php+1 −3
- typo3/sysext/form/Classes/Hooks/DataStructureIdentifierHook.php+1 −2
- typo3/sysext/form/Classes/Hooks/FormPagePreviewRenderer.php+1 −2
- typo3/sysext/workspaces/Classes/Service/AdditionalColumnService.php+1 −10
- typo3/sysext/workspaces/Classes/Service/AdditionalResourceService.php+1 −10
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+1 −10
Review log 910
-
Benni Mack uploaded patch set 1 08/05/20, 15:16
-
Oliver Klee voted on patch set 1 CR +1 08/05/20, 15:26
-
TYPO3com voted on patch set 1 V +1 08/05/20, 15:27 Completed build in 10m 59s on Wed, 5 Aug, 03:27 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4427
-
Wouter Wolters voted on patch set 1 CR +1 08/05/20, 18:38
-
Daniel Haupt voted on patch set 1 CR +1 08/06/20, 00:40
-
Anja Leichsenring commented on patch set 1 08/06/20, 04:56
works as advertised, but there is more: e.g. 'find usages' for AdditionalColumnService leads to EXT:workspaces/Controller/ReviewController->getAdditionalColumnService(), which also uses the objectManager. Is it worth the expansion? I can take care tonight if you want me to. -
Benni Mack commented on patch set 1 08/06/20, 06:37
there are a lot more, these ones are safe to be backported to v10.4 to improve performance, so it's a matter of carefully testing and evaluating. I'm actually for having multiple separate changes to see potential impact in this area instead of one large one. OK? -
Anja Leichsenring commented on patch set 1 V +1 CR +1 08/06/20, 06:37
> Patch Set 1: > > there are a lot more, these ones are safe to be backported to v10.4 to improve performance, so it's a matter of carefully testing and evaluating. I'm actually for having multiple separate changes to see potential impact in this area instead of one large one. OK? absolutely. Then go on with it. -
Frank Nägler voted on patch set 1 V +2 CR +2 08/07/20, 12:15
-
Frank Nägler merged patch set 2 08/07/20, 12:15