Review main Merged

65190[BUGFIX] Always use 'paste' wording pasting clipboard elements

Christian Kuhn CR +2 V +2 Normal +20 −49 updated 08/07/20, 08:18

Commit message

The clipboard has a 'move' and a 'copy' mode. This can be
changed in the list module where the clipboard is rendered.
Using 'cut' in context menu, the state is forced to 'move',
using 'copy' in context menu, the state is forced to 'copy'.

If there is an element in the clipboard, 'paste' icons in
list and page module appear. Their title tag is always
'paste' or 'paste after' or similar.

Only the modal in page module distinguishes between copy
and paste and changes its wording 'Do you really want
to move' vs. 'Do you really want to copy', while the
modal title is always 'paste'.

This is odd from an UX point of view: Users learned they
either 'cut + paste' or 'copy + paste': The decision to
cut or paste is the first step when selecting the element,
it's then either cut-out and moved to clipboard, or a copy
in the clipboard is added. The second step is then just
'paste here'.

The patch changes the modal wording to always use 'paste'
as second step, just like the icons already do.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1318

  1. Christian Kuhn uploaded patch set 1 08/06/20, 10:21

  2. Christian Kuhn updated the commit message in patch set 2 08/06/20, 10:22

  3. TYPO3com voted on patch set 1 V -1 08/06/20, 10:34 Completed build in 12m 40s on Thu, 6 Aug, 10:34 AM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4435

  4. TYPO3com voted on patch set 2 V -1 08/06/20, 10:38 Completed build in 15m 29s on Thu, 6 Aug, 10:38 AM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4436

  5. Christian Kuhn uploaded patch set 3 08/06/20, 10:54

  6. TYPO3com voted on patch set 3 V +1 08/06/20, 11:05 Completed build in 10m 58s on Thu, 6 Aug, 11:05 AM Test Summary: 72979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4438

  7. Christian Kuhn voted on patch set 3 CR -1 08/06/20, 15:11

  8. Christian Kuhn commented on patch set 3 08/06/20, 15:11

    will change that again.
  9. Christian Kuhn uploaded patch set 4 08/06/20, 16:01

  10. Christian Kuhn updated the commit message in patch set 5 08/06/20, 16:04

  11. TYPO3com voted on patch set 4 V +1 08/06/20, 16:13 Completed build in 11m 33s on Thu, 6 Aug, 04:13 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4451

  12. TYPO3com voted on patch set 5 V +1 08/06/20, 16:16 Completed build in 12m 11s on Thu, 6 Aug, 04:16 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4452

  13. Wouter Wolters voted on patch set 5 CR +1 08/06/20, 20:51

  14. Andreas Kienast voted on patch set 5 V +1 CR +1 08/07/20, 07:37

  15. Oli Bartsch voted on patch set 5 V +1 CR +1 08/07/20, 07:44

  16. Björn Jacob voted on patch set 5 V +1 CR +1 08/07/20, 07:56

  17. Andreas Kienast voted on patch set 5 V +2 CR +2 08/07/20, 08:18

  18. Andreas Kienast merged patch set 6 08/07/20, 08:18