Review 10.4 Merged

65198[BUGFIX] Use ADMCMD_prev to keep live version in workspace split view

Andreas Kienast CR +2 V +2 Easy +17 −11 updated 08/06/20, 22:25

Commit message

Previously, when using the "Split Preview" for comparing a workspace
version, and a live workspace, in iframes, the workspace version
received the GET Parameter "&ADMCMD_prev=1", and the live workspace
the "ADMCMD_noBeUser=1" (= no backend user is logged in) for THESE
requests.

Navigating through the live workspace, the ADMCMD_* GET parameters are
lost in both variants.

This change replaces the ADMCMD_noBeUser=1 with ADMCMD_prev=LIVE
making the options consistent naming-wise.

In addition, when ADMCMD_prev=LIVE is set, the current BE_USER
is kept but the workspace is set to "0" temporary (for this request),
allowing for e.g. the admin panel to continue to work.

When ADMCMD_prev=LIVE or ADMCMD_prev=IGNORE is set, the parameter
is added to config.linkVars, allowing to keep using the ADMCMD_prev
when browsing through the workspace and live versions in the iframes.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 34

  1. Andreas Kienast commented on patch set 1 08/06/20, 21:59

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 08/06/20, 22:22 Completed build in 15m 50s on Thu, 6 Aug, 10:21 PM Test Summary: 74019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-178

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 08/06/20, 22:25

  4. Andreas Kienast merged patch set 2 08/06/20, 22:25