Review 10.4 Merged

65199[BUGFIX] Always use 'paste' wording pasting clipboard elements

Andreas Kienast CR +2 V +2 Normal +20 −49 updated 08/07/20, 08:49

Commit message

The clipboard has a 'move' and a 'copy' mode. This can be
changed in the list module where the clipboard is rendered.
Using 'cut' in context menu, the state is forced to 'move',
using 'copy' in context menu, the state is forced to 'copy'.

If there is an element in the clipboard, 'paste' icons in
list and page module appear. Their title tag is always
'paste' or 'paste after' or similar.

Only the modal in page module distinguishes between copy
and paste and changes its wording 'Do you really want
to move' vs. 'Do you really want to copy', while the
modal title is always 'paste'.

This is odd from an UX point of view: Users learned they
either 'cut + paste' or 'copy + paste': The decision to
cut or paste is the first step when selecting the element,
it's then either cut-out and moved to clipboard, or a copy
in the clipboard is added. The second step is then just
'paste here'.

The patch changes the modal wording to always use 'paste'
as second step, just like the icons already do.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Andreas Kienast commented on patch set 1 08/07/20, 08:18

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 08/07/20, 08:30 Completed build in 11m 26s on Fri, 7 Aug, 08:30 AM Test Summary: 74019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-183

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 08/07/20, 08:49

  4. Andreas Kienast merged patch set 2 08/07/20, 08:49