65208[BUGFIX] Limit amount of data fetched by the page tree
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Marcus Schwemer +1
- Andreas Kienast +1
-
Verified V +2 Done
- Richard Haeser +2
- Uwe Trotzek +1
- Marcus Schwemer +1
- Riny van Tiggelen +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 6
- Bug #88943Pagetree taking extremely long to load for editors
- Bug #88098Page tree XHR is fetching huge JSON data
- Bug #88259Filtered pagetree should display child pages
- Bug #91884Page tree filter has no delete "X", needs hitting enter and has no filter info box anymore, a big backwards step regarding usability
- Bug #91753Pagetree not respecting getPagePermsClause()
- Task #91916Provide acceptance tests for page tree filter
Files 17
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/NavigationComponentInterface.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/PageTree.ts+1 −1
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+160 −49
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php+348 −10
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+6 −0
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTree.js+130 −4
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeElement.js+3 −0
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeToolbar.js1+15 −40
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/PageTree.js+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+98 −55
- typo3/sysext/core/Tests/Acceptance/Backend/PageTree/PageTreeFilterCest.phpnew+151 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Site/SiteModuleCest.php+6 −2
- typo3/sysext/core/Tests/Acceptance/Support/Helper/PageTree.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Support/Helper/SiteConfiguration.phpnew+39 −0
- typo3/sysext/core/composer.json+1 −1
- composer.json1+1 −1
- composer.lock+10 −360
Review log 6898
Show 4973 earlier messages
-
Benni Mack uploaded patch set 1 08/10/20, 09:37
-
Andreas Kienast commented on patch set 1 CR -1 08/10/20, 09:44
on it -
TYPO3com voted on patch set 1 V +1 08/10/20, 09:52 Completed build in 13m 46s on Mon, 10 Aug, 09:52 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4537
-
Andreas Kienast uploaded patch set 2 08/10/20, 09:54
-
TYPO3com voted on patch set 2 V +1 08/10/20, 10:06 Completed build in 11m 47s on Mon, 10 Aug, 10:06 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4539
-
Andreas Kienast commented on patch set 2 08/10/20, 10:09
PageTreeToolbar.js:204UnresolvedReminder: Debouncing is not available in v9, please check the "pre-revert" approach: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65140 -
Oliver Klee wrote 08/10/20, 11:47
Removed reviewer Oliver Klee. -
Richard Haeser uploaded patch set 3 08/10/20, 18:40
-
Richard Haeser updated the commit message in patch set 4 08/10/20, 18:42
-
TYPO3com voted on patch set 3 V +1 08/10/20, 18:52 Completed build in 11m 49s on Mon, 10 Aug, 06:52 PM Test Summary: 73001 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4554
-
TYPO3com voted on patch set 4 V +1 08/10/20, 18:55 Completed build in 12m 41s on Mon, 10 Aug, 06:55 PM Test Summary: 73001 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4555
-
Torben Hansen uploaded patch set 5 08/11/20, 05:20
-
TYPO3com voted on patch set 5 V -1 08/11/20, 05:21 Completed build in 48s on Tue, 11 Aug, 05:21 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4559
-
TYPO3com commented on patch set 5 08/11/20, 09:37 Completed build in 29s on Tue, 11 Aug, 09:37 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4565
-
Richard Haeser uploaded patch set 6 08/11/20, 09:41
-
TYPO3com voted on patch set 6 V -1 08/11/20, 09:53 Completed build in 11m 37s on Tue, 11 Aug, 09:53 AM Test Summary: 12 of 73485 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4566
-
Richard Haeser uploaded patch set 7 08/11/20, 12:36
-
Richard Haeser uploaded patch set 8 08/11/20, 12:46
-
TYPO3com voted on patch set 7 V -1 08/11/20, 12:48 Completed build in 11m 18s on Tue, 11 Aug, 12:48 PM Test Summary: 73001 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4569
-
TYPO3com voted on patch set 8 V +1 08/11/20, 12:56 Completed build in 10m 37s on Tue, 11 Aug, 12:56 PM Test Summary: 73001 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4570
-
Richard Haeser updated the commit message in patch set 9 08/11/20, 12:57
-
TYPO3com voted on patch set 9 V +1 08/11/20, 13:09 Completed build in 11m 19s on Tue, 11 Aug, 01:09 PM Test Summary: 73001 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4571
-
Anja Leichsenring uploaded patch set 10 08/11/20, 14:44
-
Anja Leichsenring commented on patch set 10 CR -1 08/11/20, 14:45
we still miss the testing-framework release the test relies on, but for verifying this is fine. -
TYPO3com voted on patch set 10 V -1 08/11/20, 14:56 Completed build in 12m 21s on Tue, 11 Aug, 02:56 PM Test Summary: 1 of 73486 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4577
-
Anja Leichsenring uploaded patch set 11 08/11/20, 14:57
-
TYPO3com commented on patch set 10 08/11/20, 15:03 Completed build in 11m 45s on Tue, 11 Aug, 03:03 PM Test Summary: 1 of 73486 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4578
-
TYPO3com voted on patch set 11 V +1 08/11/20, 15:09 Completed build in 12m 09s on Tue, 11 Aug, 03:09 PM Test Summary: 73002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4579
-
Anja Leichsenring uploaded patch set 12 08/11/20, 15:12
-
Richard Haeser commented on patch set 12 08/11/20, 15:20
composer.json:78UnresolvedIs it right that this is not a dev dependency anymore? -
TYPO3com voted on patch set 12 V -1 08/11/20, 15:23 Completed build in 10m 55s on Tue, 11 Aug, 03:23 PM Test Summary: 71986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4580
-
Anja Leichsenring commented on patch set 12 08/11/20, 15:30
> Patch Set 12: > > (1 comment) it does not matter at this point, but of course it is not correct. We need to include the correct testing-framework tag once it becomes available. -
Anja Leichsenring commented on patch set 12 CR -1 08/11/20, 15:31
waiting for the testing-framework release -
TYPO3com voted on patch set 12 V +1 08/11/20, 15:31 Completed build in 29m 41s on Tue, 11 Aug, 03:31 PM Test Summary: 73000 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4580
-
Richard Haeser commented on patch set 12 CR +1 08/11/20, 15:53
Seems fine to me! -
Richard Haeser commented on patch set 12 CR 0 08/11/20, 15:55
Will try to check with Microsoft edge (see https://forge.typo3.org/issues/91896) -
Richard Haeser commented on patch set 12 08/12/20, 13:48
> Patch Set 12: Code-Review-1 > > waiting for the testing-framework release Do I see it correctly that there is a new release for the testing-framework now? Should I update the patch with the right version of the testing framework? -
Anja Leichsenring uploaded patch set 13 08/12/20, 15:04
-
Anja Leichsenring updated the commit message in patch set 14 08/12/20, 15:05
-
TYPO3com voted on patch set 13 V +1 08/12/20, 15:16 Completed build in 12m 12s on Wed, 12 Aug, 03:16 PM Test Summary: 72999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4598
-
TYPO3com voted on patch set 14 V +1 08/12/20, 15:21 Completed build in 16m 14s on Wed, 12 Aug, 03:21 PM Test Summary: 72999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4599
-
Anja Leichsenring commented on patch set 14 V +1 CR +1 08/12/20, 18:00
tested with all the known issues and as far as possible with my small test setup. Feels nice and quick again. -
Marcus Schwemer commented on patch set 14 V -1 08/13/20, 08:11
I get a JS error, when deleting the filter at two customer projects. Cannot reproduce it on a fresh TYPO3. - filter the page tree - select a filtered page - use "x" to clear the filter - error in JS console: "Uncaught TypeError" - second click on the "x" resets the pagetree, loosing the selected page Browser: FF 79.0 (Ubuntu), Chrome 81.0 (Ubuntu) TYPO3: 10.4.7-dev (with Cherry-Pick) -
Marcus Schwemer commented on patch set 14 08/13/20, 08:33
Can reproduce it on a plain TYPO3 now. - create a nested page tree with 3 or more levels - collapse all levels up to the root - reload the pagetree - search for a page on level three or higher - click on that page in the pagetree - delete the search term via "x" => - "x" stays - second click on "x" reloads the pagetree The error does not occur, when the page tree is uncollapsed. -
Uwe Trotzek commented on patch set 14 V -1 08/13/20, 10:43
Except the issue that Marcus has found, the patch works in my testing instance. -
Richard Haeser uploaded patch set 15 08/13/20, 12:57
-
Richard Haeser commented on patch set 15 CR -1 08/13/20, 12:58
Will have a look at the feedback now -
TYPO3com voted on patch set 15 V +1 08/13/20, 13:12 Completed build in 14m 15s on Thu, 13 Aug, 01:12 PM Test Summary: 72999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4624
-
Richard Haeser uploaded patch set 16 08/13/20, 13:23
-
TYPO3com voted on patch set 16 V -1 08/13/20, 13:40 Completed build in 17m 27s on Thu, 13 Aug, 01:40 PM Test Summary: 1 of 73483 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4630
-
TYPO3com voted on patch set 16 V +1 08/13/20, 13:51 Completed build in 12m 31s on Thu, 13 Aug, 01:51 PM Test Summary: 72999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4632
-
Benni Mack uploaded patch set 17 08/13/20, 14:51
-
Benni Mack uploaded patch set 18 08/13/20, 14:52
-
TYPO3com voted on patch set 17 V -1 08/13/20, 14:52 Completed build in 25s on Thu, 13 Aug, 02:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4637
-
Markus Klein commented on patch set 18 08/13/20, 14:53
Tested with old Edge: Tree looks fine now, but D&D of a new page is only possible onto an existing page, but not in-between. -
Markus Klein commented on patch set 18 08/13/20, 15:00
Unresolved
works -
TYPO3com voted on patch set 18 V +1 08/13/20, 15:03 Completed build in 11m 30s on Thu, 13 Aug, 03:03 PM Test Summary: 72999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4638
-
Richard Haeser updated the commit message in patch set 19 08/13/20, 15:07
-
Richard Haeser commented on patch set 19 08/13/20, 15:11
> Patch Set 18: > > Tested with old Edge: Tree looks fine now, but D&D of a new page is only possible onto an existing page, but not in-between. I can't think of a change that make this not work in this patch. Can you verify if this is working in 10.4.5 or before? Otherwise I would opt to create a separate issue for that. -
Richard Haeser voted on patch set 19 V +1 CR +1 08/13/20, 15:14
-
TYPO3com voted on patch set 19 V +1 08/13/20, 15:19 Completed build in 12m 02s on Thu, 13 Aug, 03:19 PM Test Summary: 72999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4640
-
Markus Klein voted on patch set 19 V +1 CR +1 08/13/20, 17:57
-
Richard Haeser updated the commit message in patch set 20 08/13/20, 18:57
-
TYPO3com voted on patch set 20 V +1 08/13/20, 19:08 Completed build in 10m 59s on Thu, 13 Aug, 07:08 PM Test Summary: 72999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4649
-
Richard Haeser commented on patch set 20 V +1 CR +1 08/13/20, 19:19
Also verified with Microsoft Edge 44.17763.1.0 (traditional) -
Marcus Schwemer voted on patch set 20 V +1 CR +1 08/14/20, 06:40
-
Markus Klein voted on patch set 20 CR +1 08/14/20, 08:11
-
Uwe Trotzek voted on patch set 20 V +1 08/14/20, 08:18
-
Andreas Kienast commented on patch set 20 V -1 08/15/20, 17:44
Clearing the filter doesn't reset the page tree -
Andreas Kienast commented on patch set 20 08/15/20, 17:46
> Patch Set 20: Verified-1 > > Clearing the filter doesn't reset the page tree Interestingly I have to click the "X" twice. -
Andreas Kienast uploaded patch set 21 08/15/20, 17:53
-
Andreas Kienast commented on patch set 21 V -1 08/15/20, 17:55
There is something else off: - filter is active - page gets deleted via context menu - whole tree is loaded again ignoring the filter -
Andreas Kienast commented on patch set 21 08/15/20, 18:01
Another thing, it seems to be related to my previous finding: - filter is active - create a new page via drag&drop - page tree gets reloaded ignoring the filter
-
TYPO3com voted on patch set 21 V +1 08/15/20, 18:04 Completed build in 10m 39s on Sat, 15 Aug, 06:04 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4705
-
Andreas Kienast uploaded patch set 22 08/15/20, 20:14
-
Andreas Kienast uploaded patch set 23 08/15/20, 20:22
-
TYPO3com voted on patch set 22 V +1 08/15/20, 20:29 Completed build in 14m 33s on Sat, 15 Aug, 08:29 PM Test Summary: 72995 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4709
-
Andreas Kienast uploaded patch set 24 08/15/20, 20:35
-
TYPO3com voted on patch set 23 V +1 08/15/20, 20:36 Completed build in 13m 59s on Sat, 15 Aug, 08:36 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4710
-
Andreas Kienast commented on patch set 24 08/15/20, 20:38
One last thing we may have to reconsider regarding filtering: if the filter is active and a page gets deleted, it might happen that after reloading no pages are found afterwards. Should the filter get removed in such case or do we render an empty tree and the backend user has to figure out that a non-matching filter is still applied? -
TYPO3com voted on patch set 24 V +1 08/15/20, 20:47 Completed build in 12m 35s on Sat, 15 Aug, 08:47 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4711
-
Richard Haeser commented on patch set 24 08/16/20, 07:56
> Patch Set 24: > > One last thing we may have to reconsider regarding filtering: if the filter is active and a page gets deleted, it might happen that after reloading no pages are found afterwards. > > Should the filter get removed in such case or do we render an empty tree and the backend user has to figure out that a non-matching filter is still applied? I would opt to keep it as it was before this page tree patch: remove filter after delete. But maybe we should also clear the filter field. -
Anja Leichsenring uploaded patch set 25 08/17/20, 05:28
-
TYPO3com voted on patch set 25 V +1 08/17/20, 05:40 Completed build in 11m 58s on Mon, 17 Aug, 05:40 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4723
-
Richard Haeser commented on patch set 25 08/17/20, 07:19
> Patch Set 24: > > > Patch Set 24: > > > > One last thing we may have to reconsider regarding filtering: if the filter is active and a page gets deleted, it might happen that after reloading no pages are found afterwards. > > > > Should the filter get removed in such case or do we render an empty tree and the backend user has to figure out that a non-matching filter is still applied? > > I would opt to keep it as it was before this page tree patch: remove filter after delete. But maybe we should also clear the filter field. As discussed with Andreas, I created a new issue on forge so we can do a follow up on this. See https://forge.typo3.org/issues/92027 -
Markus Klein voted on patch set 25 CR +1 08/17/20, 07:24
-
Richard Haeser voted on patch set 25 V +1 CR +1 08/17/20, 08:32
-
Anja Leichsenring uploaded patch set 26 08/17/20, 08:45
-
TYPO3com voted on patch set 26 V +1 08/17/20, 08:57 Completed build in 12m 02s on Mon, 17 Aug, 08:57 AM Test Summary: 72997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4725
-
Richard Haeser voted on patch set 26 V +1 CR +1 08/17/20, 09:01
-
Andreas Kienast voted on patch set 26 V +1 CR +1 08/17/20, 09:04
-
Riny van Tiggelen voted on patch set 26 V +1 08/17/20, 09:41
-
Uwe Trotzek voted on patch set 26 V +1 08/17/20, 09:48
-
Marcus Schwemer voted on patch set 26 V +1 CR +1 08/17/20, 12:56
-
Richard Haeser voted on patch set 26 V +2 CR +2 08/17/20, 12:59
-
Richard Haeser merged patch set 27 08/17/20, 12:59
-
Oliver Hader commented on patch set 27 08/18/20, 11:58
Regression for moved pages in workspaces, see https://forge.typo3.org/issues/92041 -
Oliver Hader commented on patch set 27 08/24/20, 16:57
Confirmed regression for deleted pages in workspaces: https://forge.typo3.org/issues/92057