Review 10.4 Merged

65209[BUGFIX] Workspace preview shows correct pages in sub menus

Benni Mack CR +2 V +2 Easy +4 −1 updated 08/10/20, 10:08

Commit message

A missing restriction in PageRenderer->getSubpagesForPages()
leads to the workspace preview of a page changed in a
workspace to render both live and workspace versions as menu
items in multi level menus. Adapt the query to fetch the
correct combination of live and overlay records.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 35

  1. Benni Mack commented on patch set 1 08/10/20, 09:44

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 08/10/20, 09:57 Completed build in 12m 47s on Mon, 10 Aug, 09:57 AM Test Summary: 2 of 74493 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-193

  3. TYPO3com voted on patch set 1 V +1 08/10/20, 10:04 Completed build in 32m 43s on Mon, 10 Aug, 10:04 AM Test Summary: 74007 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-193

  4. Benni Mack voted on patch set 1 V +2 CR +2 08/10/20, 10:08

  5. Benni Mack merged patch set 2 08/10/20, 10:08