Review main Merged

65212[BUGFIX] Workspace preview shows correct pages in sub menus

Christian Kuhn CR +2 V +2 Easy +4 −1 updated 08/10/20, 09:41

Commit message

A missing restriction in PageRenderer->getSubpagesForPages()
leads to the workspace preview of a page changed in a
workspace to render both live and workspace versions as menu
items in multi level menus. Adapt the query to fetch the
correct combination of live and overlay records.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 811

  1. Christian Kuhn uploaded patch set 1 08/06/20, 12:50

  2. TYPO3com voted on patch set 1 V +1 08/06/20, 13:01 Completed build in 11m 00s on Thu, 6 Aug, 01:01 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4439

  3. Christian Kuhn uploaded patch set 2 08/06/20, 13:05

  4. TYPO3com voted on patch set 2 V -1 08/06/20, 13:17 Completed build in 11m 53s on Thu, 6 Aug, 01:17 PM Test Summary: 15 of 73465 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4440

  5. Christian Kuhn uploaded patch set 3 08/06/20, 13:40

  6. TYPO3com voted on patch set 3 V +1 08/06/20, 13:53 Completed build in 12m 02s on Thu, 6 Aug, 01:53 PM Test Summary: 72980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4441

  7. Wouter Wolters voted on patch set 3 CR +1 08/06/20, 20:55

  8. Andreas Kienast voted on patch set 3 CR +1 08/06/20, 21:04

  9. Andreas Kienast voted on patch set 3 V +1 08/06/20, 21:51

  10. Benni Mack voted on patch set 3 V +2 CR +2 08/10/20, 09:41

  11. Benni Mack merged patch set 4 08/10/20, 09:41