Review main Merged

65213[BUGFIX] Use ADMCMD_prev to keep live version in workspace split view

Benni Mack CR +2 V +2 Easy +17 −11 updated 08/06/20, 21:59

Commit message

Previously, when using the "Split Preview" for comparing a workspace
version, and a live workspace, in iframes, the workspace version
received the GET Parameter "&ADMCMD_prev=1", and the live workspace
the "ADMCMD_noBeUser=1" (= no backend user is logged in) for THESE
requests.

Navigating through the live workspace, the ADMCMD_* GET parameters are
lost in both variants.

This change replaces the ADMCMD_noBeUser=1 with ADMCMD_prev=LIVE
making the options consistent naming-wise.

In addition, when ADMCMD_prev=LIVE is set, the current BE_USER
is kept but the workspace is set to "0" temporary (for this request),
allowing for e.g. the admin panel to continue to work.

When ADMCMD_prev=LIVE or ADMCMD_prev=IGNORE is set, the parameter
is added to config.linkVars, allowing to keep using the ADMCMD_prev
when browsing through the workspace and live versions in the iframes.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 812

  1. Benni Mack uploaded patch set 1 08/06/20, 13:44

  2. TYPO3com voted on patch set 1 V -1 08/06/20, 13:59 Completed build in 14m 58s on Thu, 6 Aug, 01:59 PM Test Summary: 70228 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4442

  3. Benni Mack uploaded patch set 2 08/06/20, 14:05

  4. Benni Mack uploaded patch set 3 08/06/20, 14:09

  5. TYPO3com voted on patch set 2 V +1 08/06/20, 14:17 Completed build in 11m 41s on Thu, 6 Aug, 02:17 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4443

  6. TYPO3com voted on patch set 3 V +1 08/06/20, 14:23 Completed build in 14m 06s on Thu, 6 Aug, 02:23 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4444

  7. Benni Mack updated the commit message in patch set 4 08/06/20, 15:12

  8. Christian Kuhn voted on patch set 4 V +1 CR +1 08/06/20, 15:15

  9. TYPO3com voted on patch set 4 V +1 08/06/20, 15:24 Completed build in 12m 06s on Thu, 6 Aug, 03:24 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4448

  10. Wouter Wolters voted on patch set 4 CR +1 08/06/20, 20:53

  11. Andreas Kienast voted on patch set 4 V +2 CR +2 08/06/20, 21:58

  12. Andreas Kienast merged patch set 5 08/06/20, 21:59