Review main Merged

65214[BUGFIX] IRRE: Handle localizable records correctly

Andreas Kienast CR +2 V +2 Easy +4 −3 updated 08/25/20, 19:00

Commit message

Each node in an IRRE container now has a new `data-placeholder-record`
attribute to be able to identify such node w/out accessing CSS classes
used for styling purpose.

Nodes where `data-placeholder-record` has a truthy value are localizable
and are ignored now when the sorting is changed which solves an issue
where such records would have been moved into a different language.

In the same run the localization is fixed as it was tried to iterate an
object, which doesn't work. Alternatively, the object values are fetched
and iterated now.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1218

  1. Andreas Kienast uploaded patch set 1 08/06/20, 14:44

  2. Andreas Kienast uploaded patch set 2 08/06/20, 14:45

  3. Andreas Kienast uploaded patch set 3 08/06/20, 14:48

  4. TYPO3com voted on patch set 1 V +1 08/06/20, 14:56 Completed build in 12m 11s on Thu, 6 Aug, 02:56 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4445

  5. TYPO3com voted on patch set 2 V +1 08/06/20, 14:59 Completed build in 13m 34s on Thu, 6 Aug, 02:59 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4446

  6. TYPO3com voted on patch set 3 V +1 08/06/20, 15:02 Completed build in 12m 37s on Thu, 6 Aug, 03:02 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4447

  7. Andreas Kienast uploaded patch set 4 08/08/20, 13:44

  8. TYPO3com voted on patch set 4 V +1 08/08/20, 14:09 Completed build in 20m 50s on Sat, 8 Aug, 02:09 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4498

  9. Markus Klein voted on patch set 4 CR +1 08/13/20, 14:35

  10. Richard Haeser voted on patch set 4 CR +1 08/14/20, 08:11

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 08/25/20, 18:41

  12. Christian Kuhn uploaded patch set 5 08/25/20, 18:42

  13. Christian Kuhn commented on patch set 5 08/25/20, 18:43

    had to push again due to merge conflict in js file ... compiled again, now.
  14. TYPO3com voted on patch set 5 V -1 08/25/20, 18:54 Completed build in 11m 43s on Tue, 25 Aug, 06:54 PM Test Summary: 6 of 73578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4960

  15. Christian Kuhn voted on patch set 5 V +1 CR +1 08/25/20, 18:55

  16. TYPO3com voted on patch set 5 V +1 08/25/20, 18:59 Completed build in 28m 35s on Tue, 25 Aug, 06:59 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4960

  17. Anja Leichsenring voted on patch set 5 V +2 CR +2 08/25/20, 19:00

  18. Anja Leichsenring merged patch set 6 08/25/20, 19:00