Review main Merged

65215[BUGFIX] Do not use hard-coded magic 1337 in admin panel

Benni Mack CR +2 V +2 Easy +2 −1 updated 08/06/20, 21:41

Commit message

This change uses a "random" frontend user ID (currently 1337)
to a very unlikely number PHP_INT_MAX to ensure that no usual
frontend user is used to preview.

This line can be removed completely once
  https://review.typo3.org/c/Packages/TYPO3.CMS/+/64441
is fixed as well.

But 1337 is a no-go (that's why it needs to into 9.5)

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 08/06/20, 15:20

  2. TYPO3com voted on patch set 1 V +1 08/06/20, 15:31 Completed build in 11m 14s on Thu, 6 Aug, 03:31 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4449

  3. Benni Mack updated the commit message in patch set 2 08/06/20, 15:35

  4. TYPO3com voted on patch set 2 V +1 08/06/20, 15:46 Completed build in 11m 22s on Thu, 6 Aug, 03:46 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4450

  5. Wouter Wolters voted on patch set 2 CR +1 08/06/20, 20:52

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 08/06/20, 21:06

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 08/06/20, 21:41

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 08/06/20, 21:41

  9. Andreas Kienast merged patch set 3 08/06/20, 21:41