Review main Merged

65218[BUGFIX] Switch workspace by opening the module explicitly

Andreas Kienast CR +2 V +2 Easy +8 −2 updated 08/06/20, 21:53

Commit message

This patch changes the behavior how workspaces are switched via the
topbar menu.

The switch now happens by explicitly requesting the workspace module
with a new set `workspace` parameter. Previously, it was tried to
reload the content iframe which may has a `workspace` parameter
already set, resulting in simply reloading the previously requested
iframe.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 915

  1. Andreas Kienast uploaded patch set 1 08/06/20, 21:00

  2. Andreas Kienast updated the commit message in patch set 2 08/06/20, 21:00

  3. TYPO3com voted on patch set 1 V +1 08/06/20, 21:12 Completed build in 12m 15s on Thu, 6 Aug, 09:12 PM Test Summary: 72980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4457

  4. TYPO3com voted on patch set 2 V +1 08/06/20, 21:17 Completed build in 16m 20s on Thu, 6 Aug, 09:17 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4458

  5. Andreas Kienast uploaded patch set 3 08/06/20, 21:18

  6. Andreas Kienast uploaded patch set 4 08/06/20, 21:24

  7. Andreas Kienast uploaded patch set 5 08/06/20, 21:31

  8. TYPO3com voted on patch set 3 V +1 08/06/20, 21:32 Completed build in 13m 40s on Thu, 6 Aug, 09:32 PM Test Summary: 72979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4460

  9. Andreas Kienast uploaded patch set 6 08/06/20, 21:33

  10. TYPO3com voted on patch set 4 V +1 08/06/20, 21:37 Completed build in 12m 14s on Thu, 6 Aug, 09:37 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4461

  11. Christian Kuhn voted on patch set 6 V +1 CR +1 08/06/20, 21:40

  12. TYPO3com voted on patch set 5 V +1 08/06/20, 21:45 Completed build in 13m 01s on Thu, 6 Aug, 09:45 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4462

  13. TYPO3com voted on patch set 6 V +1 08/06/20, 21:49 Completed build in 15m 01s on Thu, 6 Aug, 09:49 PM Test Summary: 72981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4463

  14. Benni Mack voted on patch set 6 V +2 CR +2 08/06/20, 21:53

  15. Benni Mack merged patch set 7 08/06/20, 21:53