Review 9.5 Merged

65219[BUGFIX] Do not use hard-coded magic 1337 in admin panel

Andreas Kienast CR +2 V +2 Easy +2 −1 updated 08/06/20, 22:07

Commit message

This change uses a "random" frontend user ID (currently 1337)
to a very unlikely number PHP_INT_MAX to ensure that no usual
frontend user is used to preview.

This line can be removed completely once
  https://review.typo3.org/c/Packages/TYPO3.CMS/+/64441
is fixed as well.

But 1337 is a no-go (that's why it needs to into 9.5)

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 45

  1. Andreas Kienast uploaded patch set 1 08/06/20, 21:44

  2. TYPO3com voted on patch set 1 V +1 08/06/20, 21:59 Completed build in 14m 43s on Thu, 6 Aug, 09:59 PM Test Summary: 75139 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-747

  3. Christian Kuhn voted on patch set 1 CR +1 08/06/20, 22:07

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 08/06/20, 22:07

  5. Andreas Kienast merged patch set 2 08/06/20, 22:07