Review main Merged

65220[TASK] Broadcast AjaxDataHandler events

Andreas Kienast CR +2 V +2 Easy +29 −17 updated 08/08/20, 14:35

Commit message

Events sent via AjaxDataHandler are now broadcasted by using the
Broadcast Service. This change allows e.g. the topbar to listen to these
events and trigger a reload.

Broadcasting has the nice side effect that the event is sent to all
browser windows which allows multiple simultaneously opened backends
(that share the same domain) to react on that event.

To ease the integration of event listeners, the event payload sent via
classic `dispatchEvent()` is adjusted to share the same structure with
broadcasted messages.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Claus Due +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Claus Due +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 913

  1. Andreas Kienast uploaded patch set 1 08/07/20, 12:05

  2. TYPO3com voted on patch set 1 V +1 08/07/20, 12:22 Completed build in 16m 12s on Fri, 7 Aug, 12:22 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4473

  3. Susi Moog commented on patch set 1 V +1 08/07/20, 14:07

    tested in conjunction with 65221
  4. Anja Leichsenring uploaded patch set 2 08/08/20, 13:38

  5. Andreas Kienast uploaded patch set 3 08/08/20, 13:41

  6. Andreas Kienast uploaded patch set 4 08/08/20, 13:51

  7. Anja Leichsenring voted on patch set 4 V +1 CR +1 08/08/20, 13:54

  8. TYPO3com voted on patch set 2 V +1 08/08/20, 13:55 Completed build in 15m 00s on Sat, 8 Aug, 01:55 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4494

  9. TYPO3com voted on patch set 3 V -1 08/08/20, 13:58 Completed build in 17m 42s on Sat, 8 Aug, 01:58 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4495

  10. TYPO3com voted on patch set 4 V +1 08/08/20, 14:16 Completed build in 14m 22s on Sat, 8 Aug, 02:16 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4500

  11. Claus Due voted on patch set 4 V +1 CR +1 08/08/20, 14:35

  12. Anja Leichsenring voted on patch set 4 V +2 CR +2 08/08/20, 14:35

  13. Anja Leichsenring merged patch set 5 08/08/20, 14:35