Review main Merged

65222[BUGFIX] Ensure uid is integer when passing to method call

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 08/10/20, 13:12

Commit message

In case sqlite is used, the uid is not of type integer.
Therefore it is explicitly casted before passing to strictly typed
method call.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Daniel Haupt +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Haupt +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1618

  1. Daniel Siepmann uploaded patch set 1 08/07/20, 12:25

  2. TYPO3com voted on patch set 1 V -1 08/07/20, 12:26 Completed build in 28s on Fri, 7 Aug, 12:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4477

  3. Daniel Siepmann uploaded patch set 2 08/07/20, 12:27

  4. TYPO3com voted on patch set 2 V +1 08/07/20, 12:40 Completed build in 12m 44s on Fri, 7 Aug, 12:40 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4478

  5. Oliver Klee voted on patch set 2 CR +1 08/07/20, 12:44

  6. Oliver Klee commented on patch set 2 08/07/20, 12:44

    Is 9.5 affected as well?
  7. Andreas Kienast voted on patch set 2 V +1 CR +1 08/07/20, 12:46

  8. Andreas Kienast commented on patch set 2 08/07/20, 12:48

    Reply

    We don't support sqlite in 9.5
  9. Oliver Klee commented on patch set 2 08/07/20, 12:50

    Reply

    Yes, we do (according to https://get.typo3.org/ ).
  10. Andreas Kienast commented on patch set 2 08/07/20, 12:56

    Reply

    You're right, since 9.4 actually.
  11. Daniel Siepmann commented on patch set 2 08/07/20, 13:02

    Reply

    Didn't test, but can't find the code. I guess the revert feature of redirects was not part 9.x? As 9.x didn't even create redirects.
  12. Andreas Kienast commented on patch set 2 08/07/20, 13:03

    Reply Unresolved

    Fair enough ;)
  13. Daniel Haupt voted on patch set 2 CR +1 08/09/20, 20:23

  14. Daniel Haupt voted on patch set 2 V +1 08/09/20, 20:30

  15. Christian Kuhn voted on patch set 2 V +1 CR +1 08/10/20, 12:55

  16. Benni Mack voted on patch set 2 V +2 CR +2 08/10/20, 13:12

  17. Benni Mack merged patch set 3 08/10/20, 13:12

  18. Georg Ringer voted on patch set 2 V +2 CR +2 08/10/20, 13:12