Review main Merged

65223[TASK] Update build toolchain

Andreas Kienast CR +2 V +2 Expert +908 −682 updated 09/04/20, 06:38

Commit message

This patch updates some tools used for our assets generation toolchain.

Most notable changes:

- Since typescript-eslint has been updated to a new major version, its
  configuration changes slightly
- TypeScript is updated to 3.9

Executed commands:

  yarn add --dev \
      "@typescript-eslint/eslint-plugin"@^3.8.0 \
      "@typescript-eslint/parser"@^3.8.0 \
      "@typescript-eslint/typescript-estree"@^3.8.0 \
      autoprefixer@^9.8.6 \
      eslint@^7.6.0 \
      grunt-eslint@^23.0.0 \
      grunt-lintspaces@^0.9.0 \
      jasmine-core@^3.6.0 \
      karma@^5.1.1 \
      karma-coverage@^2.0.3 \
      karma-jasmine@^3.3.1 \
      terser@^5.0.0 \
      typescript@~3.9.0
  grunt build

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 25

Show 5 more files

Review log 1521

  1. Andreas Kienast uploaded patch set 1 08/07/20, 14:44

  2. TYPO3com voted on patch set 1 V +1 08/07/20, 14:55 Completed build in 10m 56s on Fri, 7 Aug, 02:55 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4480

  3. Andreas Kienast updated the commit message in patch set 2 08/07/20, 14:58

  4. TYPO3com voted on patch set 2 V +1 08/07/20, 15:10 Completed build in 11m 22s on Fri, 7 Aug, 03:09 PM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4482

  5. Daniel Haupt commented on patch set 2 V +1 CR +1 08/07/20, 15:23

    LGTM. There are some more minor updates available, e.g. jquery (v3.4.1 -> v3.5.1). What is the reason to not update those?
  6. Andreas Kienast commented on patch set 2 08/07/20, 15:41

    > Patch Set 2: Verified+1 Code-Review+1 > > LGTM. > > There are some more minor updates available, e.g. jquery (v3.4.1 -> v3.5.1). What is the reason to not update those? These libraries are not related to the build chain. For jQuery I've just pushed a patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65224 In some cases, it's rather complicated to update some dependencies, e.g. because they are breaking.
  7. Daniel Haupt commented on patch set 2 08/07/20, 15:47

    > Patch Set 2: > > > Patch Set 2: Verified+1 Code-Review+1 > > > > LGTM. > > > > There are some more minor updates available, e.g. jquery (v3.4.1 -> v3.5.1). What is the reason to not update those? > > These libraries are not related to the build chain. For jQuery I've just pushed a patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65224 > > In some cases, it's rather complicated to update some dependencies, e.g. because they are breaking. Okay, thanks for clarifying.
  8. Andreas Kienast uploaded patch set 3 08/08/20, 13:33

  9. Andreas Kienast uploaded patch set 4 08/08/20, 13:35

  10. TYPO3com voted on patch set 3 V -1 08/08/20, 13:47 Completed build in 13m 38s on Sat, 8 Aug, 01:47 PM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4492

  11. TYPO3com voted on patch set 4 V +1 08/08/20, 13:51 Completed build in 15m 39s on Sat, 8 Aug, 01:51 PM Test Summary: 72970 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4493

  12. Daniel Haupt voted on patch set 4 V +1 CR +1 08/09/20, 00:21

  13. Andreas Kienast uploaded patch set 5 08/09/20, 11:36

  14. TYPO3com voted on patch set 5 V +1 08/09/20, 11:48 Completed build in 11m 37s on Sun, 9 Aug, 11:48 AM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4521

  15. Daniel Haupt voted on patch set 5 V +1 CR +1 08/09/20, 15:34

  16. Andreas Kienast uploaded patch set 6 08/28/20, 14:59

  17. TYPO3com voted on patch set 6 V +1 08/28/20, 15:11 Completed build in 12m 06s on Fri, 28 Aug, 03:11 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5037

  18. Anja Leichsenring voted on patch set 6 V +1 CR +1 08/30/20, 15:16

  19. Christian Kuhn voted on patch set 6 V +1 CR +1 08/30/20, 15:18

  20. Benni Mack voted on patch set 6 V +2 CR +2 09/04/20, 06:37

  21. Benni Mack merged patch set 7 09/04/20, 06:38